Skip to content

Remove VPC support for the 3.8.1 bugfix release #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch_381
Choose a base branch
from

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Apr 9, 2025

VPC features will be released with 3.9.0

@ksamoray
Copy link
Collaborator

ksamoray commented Apr 9, 2025

Also policy edge stuff should be removed, it's v9.0 as well.

@annakhm annakhm force-pushed the remove-vpc-support branch from 0159902 to 4d19501 Compare April 9, 2025 16:43
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 9, 2025

/test-all

1 similar comment
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 9, 2025

/test-all

VPC features will be released with 3.9.0

Signed-off-by: Anna Khmelnitsky <[email protected]>
@annakhm annakhm force-pushed the remove-vpc-support branch from 4d19501 to a5e2d28 Compare April 10, 2025 20:52
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 10, 2025

/test-all

1 similar comment
@annakhm
Copy link
Collaborator Author

annakhm commented Apr 10, 2025

/test-all

Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, but we need to decide what to do with the resources that we already released as experimental in v380

@@ -329,19 +329,6 @@ func Provider() *schema.Provider {
"nsxt_policy_distributed_flood_protection_profile": dataSourceNsxtPolicyDistributedFloodProtectionProfile(),
"nsxt_policy_gateway_flood_protection_profile": dataSourceNsxtPolicyGatewayFloodProtectionProfile(),
"nsxt_manager_info": dataSourceNsxtManagerInfo(),
"nsxt_vpc": dataSourceNsxtVPC(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already released in v3.8.0

@@ -518,31 +505,9 @@ func Provider() *schema.Provider {
"nsxt_policy_gateway_flood_protection_profile_binding": resourceNsxtPolicyGatewayFloodProtectionProfileBinding(),
"nsxt_policy_compute_sub_cluster": resourceNsxtPolicyComputeSubCluster(),
"nsxt_policy_tier0_inter_vrf_routing": resourceNsxtPolicyTier0InterVRFRouting(),
"nsxt_vpc_security_policy": resourceNsxtVPCSecurityPolicy(),
"nsxt_vpc_group": resourceNsxtVPCGroup(),
"nsxt_vpc_gateway_policy": resourceNsxtVPCGatewayPolicy(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 were also released in v3.8.0.
If we made significant changes to them it might be the case of removing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants