Skip to content

chore: remove gogetcookie.sh #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Apr 9, 2025

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

  • Removes gogetcookie.sh as it's not used.
  • Also removes .travis.yml as it's no longer used.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added technical-debt Technical Debt chore Chore labels Apr 9, 2025
@tenthirtyam tenthirtyam self-assigned this Apr 9, 2025
@ksamoray
Copy link
Collaborator

This is being referenced here
IDK if this is being used in any way, maybe @annakhm would know.

@tenthirtyam tenthirtyam force-pushed the chore/remove-gogetcookie.sh branch from f740672 to db0533b Compare April 14, 2025 13:31
@tenthirtyam
Copy link
Collaborator Author

This is being referenced here IDK if this is being used in any way, maybe @annakhm would know.

I think an additional question is if TravisCI is still in use since this file was last updated 4 years ago a references legacy versions of of Go and it's runner.

@ksamoray
Copy link
Collaborator

@tenthirtyam I think that if we eliminate gogetcookie.sh, .travis.yml should go as well. If we keep the yml file, we should keep gogetcookie.sh as well.

@tenthirtyam
Copy link
Collaborator Author

@tenthirtyam I think that if we eliminate gogetcookie.sh, .travis.yml should go as well. If we keep the yml file, we should keep gogetcookie.sh as well.

I've seen this copied to some other provider repos, not just our own.

This script sets up a Git cookie for authenticating with a googlesource.com repository.
The cookie contains credentials (git-paul.hashicorp.com=1/...) that are likely used for accessing private repositories or performing authenticated Git operations on the googlesource.com domain, which should not be needed by this project.

@tenthirtyam tenthirtyam force-pushed the chore/remove-gogetcookie.sh branch 2 times, most recently from b4f7bed to 1a5af73 Compare April 14, 2025 17:08
- Removes `gogetcookie.sh` as it's not used.
- Also removes `.travis.yml` as it's no longer used.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam force-pushed the chore/remove-gogetcookie.sh branch from 1a5af73 to 58bd4c4 Compare April 14, 2025 17:09
@tenthirtyam tenthirtyam merged commit 2c9c3a0 into master Apr 14, 2025
6 checks passed
@tenthirtyam tenthirtyam deleted the chore/remove-gogetcookie.sh branch April 14, 2025 22:56
@tenthirtyam tenthirtyam added this to the v3.8.1 milestone Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants