-
Notifications
You must be signed in to change notification settings - Fork 86
Adding data sources for T0 & T1 gateway interfaces #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marking WIP as draft. |
af49c13
to
431a739
Compare
annakhm
reviewed
Apr 28, 2025
annakhm
reviewed
Apr 28, 2025
Let's consider having a single data source |
annakhm
reviewed
May 7, 2025
annakhm
reviewed
May 7, 2025
annakhm
reviewed
May 7, 2025
annakhm
reviewed
May 7, 2025
Signed-off-by: Arun Tony <[email protected]>
Added a generic policy search function to get the gateway to which the interface is linked to and to get resources with multiple elements. Fixed the Tier0 gateway id issue in the Tier0 interface data source by using the generic policy search function. Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
…cceptance tests and documentation forthe data source Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
…ptance tests for the same and updated the documentation Signed-off-by: Arun Tony <[email protected]>
2f206cc
to
65ba21a
Compare
Signed-off-by: Arun Tony <[email protected]>
/test-all |
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
/test-all |
annakhm
reviewed
May 28, 2025
salv-orlando
approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ksamoray
approved these changes
May 28, 2025
/test-all |
ksamoray
pushed a commit
that referenced
this pull request
Jul 2, 2025
Adding a single data source for Tier 0 & Tier 1 gateways. Added the acceptance tests and documentation for the data source Signed-off-by: Arun Tony <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.