Skip to content

Adding data sources for T0 & T1 gateway interfaces #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
May 28, 2025
Merged

Conversation

aruntony005
Copy link
Contributor

No description provided.

@aruntony005 aruntony005 changed the title Adding data source for T0 & T1 gateway interface [WIP] Adding data source for T0 & T1 gateway interface Apr 21, 2025
@tenthirtyam
Copy link
Contributor

Marking WIP as draft.

@tenthirtyam tenthirtyam marked this pull request as draft April 21, 2025 13:00
@aruntony005 aruntony005 force-pushed the gw-interfaces branch 4 times, most recently from af49c13 to 431a739 Compare April 28, 2025 14:42
@aruntony005 aruntony005 changed the title [WIP] Adding data source for T0 & T1 gateway interface Adding data sources for T0 & T1 gateway interfaces Apr 28, 2025
@aruntony005 aruntony005 marked this pull request as ready for review April 28, 2025 14:59
@aruntony005 aruntony005 requested review from ksamoray and annakhm April 28, 2025 15:00
@annakhm
Copy link
Contributor

annakhm commented Apr 28, 2025

Let's consider having a single data source nsxt_policy_gateway_interface, that would support both T0 and T1

Added a generic policy search function to get the gateway to which the interface is linked to and to get resources with multiple elements.
Fixed the Tier0 gateway id issue in the Tier0 interface data source by using the generic policy search function.

Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
…cceptance tests and documentation forthe data source

Signed-off-by: Arun Tony <[email protected]>
…ptance tests for the same and updated the documentation

Signed-off-by: Arun Tony <[email protected]>
Signed-off-by: Arun Tony <[email protected]>
@aruntony005
Copy link
Contributor Author

/test-all

@aruntony005
Copy link
Contributor Author

/test-all

Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksamoray
Copy link
Contributor

/test-all

@aruntony005 aruntony005 merged commit 16b1313 into master May 28, 2025
9 checks passed
@aruntony005 aruntony005 deleted the gw-interfaces branch May 28, 2025 12:49
ksamoray pushed a commit that referenced this pull request Jul 2, 2025
Adding a single data source for Tier 0 & Tier 1 gateways. Added the acceptance tests and documentation for the data source

Signed-off-by: Arun Tony <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants