[WIP] POC implementation of caching mechanism #1925
Conversation
| @@ -0,0 +1,119 @@ | |||
| package nsxt | |||
There was a problem hiding this comment.
Can we place this in another package? nsxt is already overloaded
| @@ -0,0 +1,139 @@ | |||
| terraform { | |||
There was a problem hiding this comment.
This file shouldn't be part of the PR
| @@ -0,0 +1,79 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This file shouldn't be part of the PR
| @@ -0,0 +1,7 @@ | |||
| TIMESTAMP VPC_COUNT SUBNET_COUNT PLAN_SECONDS APPLY_SECONDS STATUS PLAN CACHE_ENABLED | |||
There was a problem hiding this comment.
This file shouldn't be part of the PR
|
|
||
| type cache struct { | ||
| mu sync.RWMutex | ||
| data map[string]map[string]*data.StructValue //key: query , key DisplayName and objects |
There was a problem hiding this comment.
The mutex here is for the entire cache - I think that this is inefficient.
IMO data here can be a `map[string]
Where struct contains the map and a mutex - we have no issue with access to the cache of VpcSubnet while accessing the cache of some other type.
I guess that this will require some changes though as data is keyed by query string - IDK if this is doable.
| } | ||
|
|
||
| // SetCacheEnabled allows enabling/disabling cache for benchmarking | ||
| var cacheEnabled = os.Getenv("NSXT_ENABLE_CACHE") == "true" |
There was a problem hiding this comment.
This should be also enabled/disabled by a provider-level attribute - you can use allow_unverified_ssl as an example for how to use both environment var and a provider attribute for activation
No description provided.