-
Notifications
You must be signed in to change notification settings - Fork 5
Improve documentation and add HCL examples #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adambarreiro @Didainius and #lvirbalas,
Might I suggest including the following for a better docs experience:
git mv TESTING.md docs/testing.md
git mv TROUBLESHOOTING.md docs/troubleshooting.md
git mv CODING_GUIDELINES.md docs/coding-guidelines.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created and destroyed the provided example from scratch - it worked.
Signed-off-by: abarreiro <[email protected]>
35b7b8b
to
83f9860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting improvements in-line.
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have these examples here! Thanks!
Hi Ryan, after discussing we kind of reverted, just to have a clear separation between "user-facing docs" in As per the README.md, I improved it with the badges and a bit of cleanup. Thanks for the suggestions! |
This PR does two things:
Also improves some leftovers in vcfa_supervisor_namespace