Skip to content

Improve documentation and add HCL examples #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 16, 2025

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Apr 14, 2025

This PR does two things:

  • Reorganises and improves the markdown documents present in this repo.
  • Adds HCL examples to help customers to use the provider

Also improves some leftovers in vcfa_supervisor_namespace

abarreiro added 8 commits April 14, 2025 10:17
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro self-assigned this Apr 14, 2025
#
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review April 14, 2025 10:24
abarreiro added 3 commits April 14, 2025 12:26
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro changed the title WIP: Improve documentation and add HCL examples Improve documentation and add HCL examples Apr 14, 2025
Copy link

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adambarreiro @Didainius and #lvirbalas,

Might I suggest including the following for a better docs experience:

git mv TESTING.md docs/testing.md
git mv TROUBLESHOOTING.md docs/troubleshooting.md
git mv CODING_GUIDELINES.md docs/coding-guidelines.md

Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created and destroyed the provided example from scratch - it worked.

fmt
Signed-off-by: abarreiro <[email protected]>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting improvements in-line.

abarreiro added 4 commits April 16, 2025 09:24
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have these examples here! Thanks!

@adambarreiro
Copy link
Collaborator Author

@adambarreiro @Didainius and #lvirbalas,

Might I suggest including the following for a better docs experience:

git mv TESTING.md docs/testing.md
git mv TROUBLESHOOTING.md docs/troubleshooting.md
git mv CODING_GUIDELINES.md docs/coding-guidelines.md

Hi Ryan, after discussing we kind of reverted, just to have a clear separation between "user-facing docs" in docs and "developer-facing docs" in the root directory, where any potential contributor can easily find them.

As per the README.md, I improved it with the badges and a bit of cleanup.

Thanks for the suggestions!

@adambarreiro adambarreiro merged commit d23e45c into vmware:main Apr 16, 2025
2 checks passed
@adambarreiro adambarreiro deleted the improve-docs branch April 16, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants