-
Notifications
You must be signed in to change notification settings - Fork 91
fix: add recreate_if_expired_at
attribute
#576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jonathan Biegert <[email protected]>
recreate_if_expired_at
attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing on the lint.
run golangci-lint
only new issues on pull_request: /tmp/tmp-5435-EsOXVA5EYXCV/pull.patch
Running [/home/runner/golangci-lint-1.60.3-linux-amd64/golangci-lint run --new-from-patch=/tmp/tmp-5435-EsOXVA5EYXCV/pull.patch --new=false --new-from-rev= --issues-exit-code=1] in [/home/runner/work/terraform-provider-vra/terraform-provider-vra] ...
Error: vra/resource_deployment.go:65:9: unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
func(ctx context.Context, d *schema.ResourceDiff, meta interface{}) bool {
^
Error: issues found
Marking as draft until ready for review.
4418987
to
af0ec80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@azrdev - the action is failing on the following:
Error: vra/resource_deployment.go:65:52: unused-parameter: parameter 'meta' seems to be unused, consider removing or renaming it as _ (revive)
func(_ context.Context, d *schema.ResourceDiff, meta interface{}) bool {
^
You can install golangci-lint
and run it locally from the root of the project with golangci-lint run
.
more idiomatic Go. Change requested by @tenthirtyam Signed-off-by: Jonathan Biegert <[email protected]>
af0ec80
to
e0e76f7
Compare
@tenthirtyam thanks for your patience, and sorry for not running the linter in the first place. I did so now locally, and get no more findings with e0e76f7 |
#514 was auto-closed before I noted @tenthirtyam requested changes. I now implemented these, please re-check
for PR context, see #473 especially #473 (comment)