feat: add usb controller #2280
Closed
feat: add usb controller #2280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
burnsjared0415
force-pushed
the
feat-r/vsphere_virtual_machine-add-usb-controller
branch
from
1420065 to
2ca7685
Compare
tenthirtyam
reviewed
Oct 9, 2024
tenthirtyam
reviewed
Oct 9, 2024
tenthirtyam
reviewed
Oct 9, 2024
tenthirtyam
reviewed
Oct 9, 2024
tenthirtyam
reviewed
Oct 9, 2024
burnsjared0415
force-pushed
the
feat-r/vsphere_virtual_machine-add-usb-controller
branch
2 times, most recently
from
647a6a0 to
6feba9c
Compare
tenthirtyam
reviewed
Oct 11, 2024
tenthirtyam
reviewed
Oct 11, 2024
tenthirtyam
reviewed
Oct 11, 2024
tenthirtyam
reviewed
Oct 11, 2024
tenthirtyam
reviewed
Oct 11, 2024
tenthirtyam
requested changes
Oct 11, 2024
Contributor
tenthirtyam
left a comment
tenthirtyam
left a comment
There was a problem hiding this comment.
Left some thoughts on supporting only a single USB controller for each supported version based on the configuration maximums in v7 and v8.
tenthirtyam
changed the title
tenthirtyam
force-pushed
the
feat-r/vsphere_virtual_machine-add-usb-controller
branch
from
a320867 to
26ca59d
Compare
tenthirtyam
force-pushed
the
feat-r/vsphere_virtual_machine-add-usb-controller
branch
from
26ca59d to
e276eb7
Compare
Contributor
|
Marking this one as ready for review after post-transfer rebase. |
Add the ability to add usb controller on build and modification of virtual machine. Signed-off-by: Jared Burns <[email protected]>
Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam
force-pushed
the
feat-r/vsphere_virtual_machine-add-usb-controller
branch
from
e276eb7 to
9d841a1
Compare
Contributor
|
Will cherry-pick portions and reimpement in v2.15.0. |
tenthirtyam
removed
documentation
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warning
TESTING IS PENDING
Add the ability to add usb controller on build and modification of virtual machine.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Closes #620