fix: simultaneous attempts to create parent directories

[skevir]

Description

This PR fixes the functionality that attempts to cope with a directory already existing when creating the parent directories for a vsphere_virtual_disk resource. For VSAN datastores it has been observed that multiple simultaneous attempts to create the same parent directories can result in vSphere reporting errors.

A previous attempt to fix this (under #639) appears to be flawed, in that the error message the functionality is triggered off is actually slightly different to what the code is written to expect. Additionally, there is different error that is sometimes hit in the same scenario, and the original fix didn't handle that case at all.

To capture both of these cases, as well as any other errors that might be seen in the future, I have changed the implementation to ignore the error hit when attempting to create the parent directories and use the existing functionality that performs a post-check that the directory now exists to determine if the creation was successful.

Testing

I have installed a fixed version of the provider and tested the following. In all case I have performed the test both in the case when the directory doesn't already exist, as well as when it does:

• creating multiple vsphere_virtual_disk resources in the same directory using separate definitions in the Terraform config file.
• creating multiple vsphere_virtual_disk resources using the count field on a single resource definition in the Terraform config file.

In the cases that would have previously failed (that is, when the directory didn't already exist) I have confirmed, by looking at the debug logs, that errors were reported when trying to create the directories for some of the vsphere_virtual_disk resources to verify that the bug fix was being invoked.

Acceptance tests

• Have you added an acceptance test for the functionality being added? I do not believe any new acceptance tests are required due to the nature of the bug being fixed.
• Have you run the acceptance tests on this branch? No - the code change seems contained enough that the live testing I have performed feels adequate.

Output from acceptance testing:

Not run

Release Note

Release note for CHANGELOG:

BUG FIX:
`resource/vsphere_virtual_disk`: Fix handling of the creation of parent directories hitting "already exists" errors.

References

Closes #2309
PR for previous fix attempt: #639

[tenthirtyam]

Hi, @skevir! 👋🏻 The HashiCorp CLA needs to be signed before this pull request can proceed.

[skevir]

Hi, @skevir! 👋🏻 The HashiCorp CLA needs to be signed before this pull request can proceed.

Thanks - I'm just confirming with my company's legal department that they are happy for me to sign. Once I have that, I will remove the "Draft" status for this PR so that it can proceed.

[tenthirtyam]

I'm just confirming with my company's legal department that they are happy for me to sign.

Understood! Note that right now the commit is signed-off with your no-reply that does not designate an employer. So be mindful if you need to agree to the CLA as an individual contrinutor or through your employer.

Merge: 7a288618 9ad0f32c
Author: skevir <[email protected]>
Date:   Mon Mar 31 17:03:54 2025 +0100

[spacegospod]

@skevir the diff looks good!
Can you please sign your last commit and mark the PR as ready (non-draft)

Commit updated.

[tenthirtyam]

lgtm