Skip to content

feat: attach sparse .vmdk when creating r/virtual_machine #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

spacegospod
Copy link
Contributor

@spacegospod spacegospod commented Apr 22, 2025

Description

Allow for the creation of VMs using existing 2gb sparse disks.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Added an acceptance test with instructions how to prepare the testing environment.
The test is disabled by default.

  ✅ TestAccResourceVSphereVirtualMachine_addDevices (1m56.92s)
  ✅ TestAccResourceVSphereVirtualMachine_basic (1m26.03s)
  ✅ TestAccResourceVSphereVirtualMachine_hardwareVersionBare (1m18.51s)
  ✅ TestAccResourceVSphereVirtualMachine_hardwareVersionClone (2m1.26s)
  ✅ TestAccResourceVSphereVirtualMachine_hardwareVersionUpgrade (2m5.53s)
  ✅ TestAccResourceVSphereVirtualMachine_highDiskUnitNumbers (1m27.91s)
  ✅ TestAccResourceVSphereVirtualMachine_highDiskUnitsToRegularSingleController (2m20.41s)
  ✅ TestAccResourceVSphereVirtualMachine_ignoreValidationOnComputedValue (42.62s)
  ✅ TestAccResourceVSphereVirtualMachine_moveToFolder (1m48.05s)
  ✅ TestAccResourceVSphereVirtualMachine_multiDevice (1m21.23s)
  ✅ TestAccResourceVSphereVirtualMachine_reCreateOnDeletion (1m56.05s)
  ✅ TestAccResourceVSphereVirtualMachine_removeMiddleDevices (2m8.81s)
  ✅ TestAccResourceVSphereVirtualMachine_removeMiddleDevicesChangeDiskUnit (2m7.67s)
  ✅ TestAccResourceVSphereVirtualMachine_scsiBusSharing (2m0.19s)
  ✅ TestAccResourceVSphereVirtualMachine_scsiBusSharingUpdate (2m43.42s)
  ✅ TestAccResourceVSphereVirtualMachine_shutdownOK (1m34.56s)

Release Note

Release note for CHANGELOG:

Support creating VM from existing 2GB sparse VMDK

References

Closes #2367

@spacegospod spacegospod self-assigned this Apr 22, 2025
@spacegospod spacegospod requested a review from a team as a code owner April 22, 2025 14:46
@spacegospod spacegospod marked this pull request as draft April 22, 2025 14:48
@tenthirtyam tenthirtyam modified the milestone: On Deck Apr 22, 2025
@tenthirtyam tenthirtyam changed the title [Draft] Support attaching existing sparse VMDK when creating VM [wip] Support attaching existing sparse VMDK when creating VM Apr 29, 2025
@tenthirtyam tenthirtyam force-pushed the main branch 2 times, most recently from 2d0d0cd to 3ebb159 Compare May 6, 2025 00:35
@tenthirtyam tenthirtyam force-pushed the prototype/sparse-disk branch from 5129183 to 11513be Compare May 6, 2025 02:30
@github-actions github-actions bot added provider Provider needs-review Needs Review labels May 6, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label May 6, 2025
@tenthirtyam tenthirtyam force-pushed the prototype/sparse-disk branch from 11513be to 99cc4cb Compare May 7, 2025 01:05
@tenthirtyam tenthirtyam changed the title [wip] Support attaching existing sparse VMDK when creating VM [wip] feat: attach sparse .vmdk when creating r/virtual_machine May 7, 2025
@github-actions github-actions bot added the needs-review Needs Review label May 7, 2025
@tenthirtyam tenthirtyam removed the needs-review Needs Review label May 7, 2025
@tenthirtyam tenthirtyam removed the provider Provider label May 30, 2025
@spacegospod spacegospod force-pushed the prototype/sparse-disk branch from 99cc4cb to 177fc9d Compare June 2, 2025 10:41
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
@github-actions github-actions bot added provider Provider needs-review Needs Review labels Jun 2, 2025
@spacegospod spacegospod force-pushed the prototype/sparse-disk branch from 177fc9d to ec48458 Compare June 2, 2025 10:41
@github-actions github-actions bot added the size/l Relative Sizing: Large label Jun 2, 2025
@spacegospod spacegospod changed the title [wip] feat: attach sparse .vmdk when creating r/virtual_machine feat: attach sparse .vmdk when creating r/virtual_machine Jun 2, 2025
@spacegospod spacegospod marked this pull request as ready for review June 2, 2025 10:42
@spacegospod spacegospod requested a review from a team as a code owner June 2, 2025 10:42
@tenthirtyam tenthirtyam added enhancement Enhancement and removed needs-review Needs Review labels Jun 2, 2025
@tenthirtyam tenthirtyam added this to the v2.14.0 milestone Jun 2, 2025
@github-actions github-actions bot added the needs-review Needs Review label Jun 2, 2025
@tenthirtyam tenthirtyam merged commit ddbedaf into main Jun 2, 2025
14 checks passed
@tenthirtyam tenthirtyam deleted the prototype/sparse-disk branch June 2, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement needs-review Needs Review provider Provider size/l Relative Sizing: Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/virtual_machine: error: unsupported type (type *types.VirtualDiskSparseVer2BackingInfo)
2 participants