Open
Conversation
aosemp
commented
Dec 3, 2020
aosemp
commented
- fix build failed on windows
- fix crash if "-L" has not been set
- fix pos error after #include
2. fix crash if "-L" has not been set 3. fix pos error after #include
Owner
|
Thank you for the pull request and working on Windows. Right now I am also working on Windows port. I have already the same fixes (e.g. last_slash) in my local repository. There will many patches coming the next 2 weeks. Currently Win64 port is broken. Although logzero did a lot of work to implement windows call ABI, still many changes should be done for implementing Windows call ABI fully (especially after recent changes in MIR to implement x86_64 system V ABI). Also a lot of work should be done to make c2m working on Windows. I'll incorporate some your pull request changes into my local repository. Please be patient. |
Author
|
That's great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.