Revert "refactor(deps): upgrade @vocdoni/davinci-sdk"#46
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous upgrade to @vocdoni/davinci-sdk from version 0.0.3 back to 0.0.2. The changes remove SDK-based process creation and event listening functionality, reverting to the older direct API approach for creating voting processes.
Key changes:
- Downgrade
@vocdoni/davinci-sdkfrom ~0.0.3 to ~0.0.2 - Remove SDK initialization and event listener setup from VocdoniApiContext
- Replace SDK-based process creation stream with direct API calls and smart contract interactions
- Remove
useCallbackwrappers from several provider functions
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Downgrades davinci-sdk version from 0.0.3 to 0.0.2 |
| src/contexts/vocdoni-api-context.tsx | Removes SDK instance, simplifies to only expose API service |
| src/components/create-vote-form.tsx | Replaces SDK stream-based process creation with manual API and contract calls |
| src/hooks/use-unified-provider.ts | Removes useCallback wrappers from provider functions |
| src/contexts/MiniAppContext.tsx | Removes useCallback wrapper from getFarcasterEthereumProvider |
| src/router.tsx | Updates destructuring to match new context API |
| src/hooks/use-vote-status.ts | Updates destructuring to match new context API |
| src/hooks/use-process-query.ts | Updates type annotation and destructuring for new context API |
| src/contexts/election-context.tsx | Updates destructuring to match new context API |
| src/components/vote-display.tsx | Updates destructuring to match new context API |
| src/components/vote-actions.tsx | Updates destructuring to match new context API |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
src/hooks/use-unified-provider.ts:1
- The React import is unnecessary since no JSX or React types are used in this file. Remove the unused import.
/* eslint-disable @typescript-eslint/no-explicit-any */
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🚀 Deployed on https://691d8e20bd68b14a9a5ddf73--davinci-ui.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commits 1cbf572 and 589adde with some manual tweaks due to lots of other changes