feat: render metadata images and description in choices #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This standardizes what @selankon did in PR #205. Such PR has not been accepted because it's into another PR that never got approved for not being really required. From the original PR, some changes have been done: - The modal will only render if both default and thumbnail images are defined. - When only default is defined, no modal will be rendered - Anatomy keys have been renamed for simplicity - A cast to any was required in choice.meta since the required SDK changes never got an official version - TODO: description should be renderable directly in the choices, not just in the modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This standardizes* what @selankon did in PR #205. Such PR has not been accepted because it's into another PR that never got approved for not being really required.
From the original PR, some changes have been done:
* standardized so it can be merged to
main, rather than to a specific branch with more changes