fix/downgrade go and ipfs#1394
Open
altergui wants to merge 4 commits into
Open
Conversation
altergui
commented
Sep 18, 2024
altergui
commented
Contributor
- Revert "update to go 1.23.0"
- Revert "go.mod: update ipfs/kubo to v0.29.0"
- Revert "all: use slices.Backward from Go 1.23"
This reverts commit 7f53ca4. we noticed a goroutine leak since this update, likely related to ipfs
This reverts commit 88b17fc. we noticed a memleak since this update Conflicts: go.mod resolved by not downgrading go-sqlite3, leave it at v1.14.23, and also leave go-multiaddr at v0.12.4
This reverts commit baef75f. since we downgraded go back to 1.22
This reverts commit e65c7ca. since we downgraded go back to 1.22
Pull Request Test Coverage Report for Build 10921346340Details
💛 - Coveralls |
Contributor
|
Do you have more details about this leak? Downgrading all of this is rather unfortunate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.