feat(ui): polish language and testimonial experience#76
Merged
Conversation
|
🚀 Deployed on https://69f9caaf75605c456b91d6b3--vocdoni-io.netlify.app |
elboletaire
approved these changes
May 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR polishes localized UI copy, updates testimonial metadata/translations, and adjusts motion/testimonial presentation for a smoother UX—especially during fast scrolling and across responsive breakpoints.
Changes:
- Refines copy/typography (removing em dashes) and updates testimonial organization names across locales and runtime testimonial data.
- Updates reveal animation timing/margins and makes the testimonial marquee responsive to viewport column count with tuned auto-scroll durations.
- Adjusts language switcher behavior/props in an attempt to preserve scroll position during locale changes.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/guardrails/check-dynamic-translation-keys.mjs | Copy guideline-aligned console output (remove em dashes). |
| locales/es/common.json | Spanish copy punctuation cleanup + testimonial org name updates. |
| locales/en/common.json | English testimonial org name updates + added platform_name translation key. |
| locales/ca/common.json | Catalan testimonial org name updates + added platform_name translation key. |
| lib/testimonials-data.ts | Updates testimonial handles/org names and aligns some fallback copy punctuation. |
| components/ui/motion-preset.tsx | Adjusts in-view margin and scales/caps transition timing for in-view reveals. |
| components/shadcn-studio/blocks/use-cases/use-cases-grid.tsx | Comment copy cleanup (remove em dashes). |
| components/shadcn-studio/blocks/testimonials-component-03/testimonials-component-03.tsx | Responsive column-count marquee layout + per-column-count durations. |
| components/shadcn-studio/blocks/about-us-page-07/about-us-page-07.tsx | Comment copy cleanup (remove em dashes). |
| components/Link.tsx | Adds a keep-scroll-position anchor prop to be forwarded to <a>. |
| components/legal/terms/TermsES.tsx | Legal footer punctuation cleanup (remove em dash). |
| components/legal/terms/TermsEN.tsx | Legal footer punctuation cleanup (remove em dash). |
| components/legal/terms/TermsCA.tsx | Legal footer punctuation cleanup (remove em dash). |
| components/LanguageSwitcher.tsx | Dropdown behavior tweaks + attempts to preserve scroll on locale switching. |
| components/app/CleanYoutubePlayer.tsx | Comment copy cleanup (remove em dashes). |
| components/app/AppHeroWithVideo.tsx | Subtitle punctuation tweak (remove em dash). |
| AGENTS.md | Updates copy guideline wording re: avoiding em dashes. |
Comment on lines
33
to
37
| export interface LinkProps extends React.AnchorHTMLAttributes<HTMLAnchorElement>, VariantProps<typeof linkVariants> { | ||
| href: string | ||
| locale?: Locale | ||
| 'keep-scroll-position'?: 'true' | 'false' | ||
| } |
Comment on lines
56
to
63
| return ( | ||
| <DropdownMenuItem key={lang.value} asChild> | ||
| <Link | ||
| href={href} | ||
| locale={lang.value} | ||
| onClick={() => setLocalePreference(lang.value)} | ||
| keep-scroll-position='true' | ||
| onClick={handleClick} | ||
| variant='dropdownItem' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm validatereact-i18nextpnpm translationswas run orpnpm guardrails:translationspasses cleanly