pg: fix login #560
Open
pg: fix login #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix locator for error message in login process
Refactor login error handling to check for alert presence before accessing error text.
Updated user name retrieval with error handling and improved locator.
Updated VNC lock file removal and logging options.
Removed debug echo statements for VNC password handling and adjusted VNC server launch command to suppress output.
Wob76 patch 1
username was still not being found, trying something else
Further tweak to attemp to read username before adding something to click the drop down
Added code to open dropdown and retrieve username.
Owner
|
Thanks! Haven't tested the login code for a while. I'll check, maybe the code works for all regions (DE here). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was having issues with Prime Gaming in the dev branch, it was not detecting the login process, I could see it getting to the OTP screen in VNC, but the would error out with a failure, this may be due to region (I am in AU).
I have not worked with this stuff before so I've used AI to help with edits as I've done the troubleshooting, watching VNC and gathering page data from what was loading, the intial error seemed to be a timing issue and the AI suggested error handeling seems to cope with this now.
I could see some elements seem different for me, I did not have a "user-dropdown-first-name-text" at all as such after a couple of attempted fixes it was working to log in, but still not getting the username so I have added a click on the drop down and a wait, this is now working for me. This may need some testing in other regions to see if '[data-a-target="FirstName"] is valid for others, maybe extend the check for both? but even if username is not returned the extra error handling continues rather than erroring out for me.
I was also having issues with runs after the inital one, it would not launch VNC, seems there was another lock file in the image, I expanded that to "rm -f /tmp/.X1-lock /tmp/.X11-unix/X1 ~/.vnc/*:1.pid" which resolved the issue for me.
Thanks,
Wob