Skip to content

Use pseudofs functions already defined in lib.sh #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsndqst
Copy link
Contributor

@tsndqst tsndqst commented Jan 16, 2025

The current mount_pseudofs() and umount_psuedofs() functions don't always allow umount to work properly.
The following errors are resolved by using the mount_pseudofs() and umount_psuedofs() functions from lib.sh.
The current functions are very similar to the ones in lib.sh so it seems like a useful change.
The lib.sh functions were updated in #245 to include --make-rslave which resolved these issues in the past for other scripts.

[10/11] Generating squashfs image (xz) from rootfs...
umount: /home/tsandqui/Code/void-mklive/mklive-build.lWvxd/image/rootfs/sys/fs/cgroup: target is busy.
ERROR: failed to unmount /home/tsandqui/Code/void-mklive/mklive-build.lWvxd/image/rootfs/sys/
umount: /home/tsandqui/Code/void-mklive/mklive-build.lWvxd/image/rootfs/sys/fs/cgroup: target is busy.
ERROR: failed to unmount /home/tsandqui/Code/void-mklive/mklive-build.lWvxd/image/rootfs/sys/

@classabbyamp
Copy link
Member

iirc i tried this and it made things worse? maybe I was doing something weird.

@tsndqst
Copy link
Contributor Author

tsndqst commented Jan 16, 2025

That could be. I don't use mklive.sh very often. The other day I was cleaning up from a failed run and ended up deleting the host's /dev mount point. Luckily it worked find when I rebooted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants