Skip to content

gsmartcontrol: update to 2.0.2 #55098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gc-user
Copy link
Contributor

@gc-user gc-user commented Apr 17, 2025

Long overdue update which brings nvme support.

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

I built this PR locally for my native architecture, (x86_64-glibc)

Someone please check the template. I had to make some changes via try&error due to upstream changes: the download url is different due to no tar.bz2 file available anymore, and the build-style changed according to these changes since v2.0.0:

  • A lot of code has been refactored and modernized using C++17 and C++20 features, removing much of the custom library code.
  • The build process requires a C++20-compliant compiler now (GCC 13+, Clang 17+, Apple Clang 15+).
  • CMake (3.14+) is now used as a build system instead of autotools.

That's why I made the lucky guess to change the build_style to cmake.

It builds and runs on my system, but someone who actually knows how to correctly create a template file better check if what I did is ok. :-)
Thanks!

Long overdue update which brings nvme support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant