Skip to content

New package: boxflat-1.30.0. #55186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sornig
Copy link
Contributor

@sornig sornig commented Apr 25, 2025

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • x86_64-musl (crossbuild)
    • i686 (crossbuild)
    • aarch64 (crossbuild)
    • aarch64-musl (crossbuild)
    • armv6l (crossbuild)

@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Apr 25, 2025
@sornig
Copy link
Contributor Author

sornig commented Apr 25, 2025

Added a patch because Boxflat expects the udev rule in /etc/udev/rules.d instead of /usr/lib/udev/rules.d (where I installed it) and thus always launches with a popup screen (wrongfully) complaining about the missing udev rule. Will try to submit a more elegant solution to the problem upstream and will probably remove the patch with a future update.

Also, I'm not sure if the INSTALL file is the correct place for those udevadm commands. At first I tried post_install() because the Arch Linux PKGBUILD does the same, but that seems to work differently in Void.

@biopsin
Copy link
Contributor

biopsin commented Apr 27, 2025

There is no need to patch, you should instead use conf_files.

conf_files A list of configuration files the binary package owns; this expects full
paths, wildcards will be extended, and multiple entries can be separated by blanks.
Example: conf_files="/etc/foo.conf /etc/foo2.conf /etc/foo/*.conf".

Fix depends to use all 80 char and the INSTALL file looks missplaced here.

@classabbyamp
Copy link
Member

no, it should be patched. /etc is the wrong place for packaged udev rules

sornig and others added 2 commits April 27, 2025 20:04
Co-authored-by: classabbyamp <[email protected]>
Fix a bunch of `Place X after depends=` errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants