Skip to content

New package: better-control-6.11.2 #55199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fccapria
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64-musl
    • aarch64

@fccapria
Copy link
Contributor Author

Before merging:
Some packages like NetworkManager or bluez are needed to access the services offered in the software but they are not direct dependencies (the program still works making the functions accessible for the installed dependencies)
How can I suggest, after installing the package, the dependencies for the correct functioning?

@fccapria fccapria force-pushed the bettercontrol-init branch from 434a46c to d1649cd Compare April 27, 2025 11:26
@fccapria fccapria changed the title New package: better-control-6.11.1 New package: better-control-6.11.2 Apr 27, 2025
@fccapria fccapria force-pushed the bettercontrol-init branch from d1649cd to f3ddbf3 Compare April 27, 2025 11:27
@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Apr 27, 2025
@biopsin
Copy link
Contributor

biopsin commented Apr 28, 2025

There is INSTALL.msg but not shure how well it will be recieved.

@xavierfortier1
Copy link
Contributor

@fccapria First of all, thank you for this package, this app looks great! Unfortunately I can't answer your question, as I actually have the same one, sorry.

However, I think it would be a good idea to remove the betterctl script which is installed using the Makefile. This package handles updates and uninstallation, so I don't think the script is needed. Other people could give their opinion on this.

Personally, I did it with:

post_install() {
    rm "${DESTDIR}/usr/bin/betterctl"
}

Let me know what you think!

@fccapria
Copy link
Contributor Author

There is INSTALL.msg but not shure how well it will be recieved.

Thank you, that's what I was looking for! Only the manual explicitly says to use these messages in case of "breaking changes" or similar. Now I'll evaluate, thanks for the suggestion.

@fccapria
Copy link
Contributor Author

fccapria commented Apr 28, 2025

post_install() {
    rm "${DESTDIR}/usr/bin/betterctl"
}

@xavierfortier1 Thank you, I appreciate that you like this package! I'm trying to include it on void because it's a project that seems very interesting and I don't think there is a package like that based on gtk. Anyway, thank you for the suggestion, you are absolutely right! Tomorrow, more calmly I'll integrate the code to the TEMPLATE and add you as a co-author of the commit.

@xavierfortier1
Copy link
Contributor

@fccapria Happy to help! It's not necessary to add me as a co-author. You get all the credits for that 😄

@fccapria fccapria force-pushed the bettercontrol-init branch from 1bf3398 to 574fb03 Compare April 29, 2025 14:01
@fccapria fccapria force-pushed the bettercontrol-init branch from dec06ed to ab0a18c Compare April 29, 2025 14:04
@fccapria
Copy link
Contributor Author

@xavierfortier1 just added the lines that you suggested! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants