Split registration out of /-/publish into a dedicated /-/register#53
Merged
Conversation
The register boolean added in #52 made one endpoint do two jobs. Publishing now only stores metas (empty packages is always a 400), and the new /-/register endpoint registers the ref, stamping publishedAt at the moment the release becomes visible. The action's final call moves to /-/register. BREAKING for older action pins: /-/publish no longer registers, so an action pinned before this commit will store artifacts but never make a NEW sha visible. Bump the vite-plus pin to this commit together with deploying it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #52: the
registerboolean made/-/publishdo two jobs. Now:POST /-/publish {ref, packages}: stores metas only, never registers. An emptypackagesis always a 400.POST /-/register {ref, prUrl?}(new): registers the ref, making its published versions visible; stampspublishedAtat the moment the release actually becomes installable.The action's final call moves to
/-/register; its per-package publish calls just drop the flag. Docs updated.BREAKING: coordinate the deploy with a pin bump
/-/publishno longer registers, so any action pinned to an older commit (vite-plus currently pinsf867796) will store artifacts but never make a NEW sha visible after this deploys. Merge order:publish-to-pkg.pr.new.ymlto this merge commit(Re-publishes of already-registered shas keep working in the gap; only brand-new shas are affected.)
Test plan
pnpm typecheck, action bundle rebuilt