Skip to content

build: split vite plus core and test#319

Merged
Brooooooklyn merged 1 commit into
mainfrom
11-25-build_split_vite_plus_core_and_test
Nov 26, 2025
Merged

build: split vite plus core and test#319
Brooooooklyn merged 1 commit into
mainfrom
11-25-build_split_vite_plus_core_and_test

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings November 25, 2025 03:44

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures the vite-plus monorepo by splitting the core vite and vitest functionality into separate packages (@voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-test), while the CLI package (@voidzero-dev/vite-plus) now serves as a thin wrapper that re-exports from these packages.

Key changes:

  • Split vite functionality into @voidzero-dev/vite-plus-core package
  • Split vitest functionality into @voidzero-dev/vite-plus-test package
  • Updated CLI to import from and re-export the new packages
  • Updated workspace configuration and build processes

Reviewed changes

Copilot reviewed 90 out of 97 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vite.config.ts Updated import path from /config to root package
tsconfig.json Added references to new core and test packages
pnpm-workspace.yaml Updated workspace overrides to use new split packages and bumped tsdown version
packages/tools/src/utils.ts Code formatting changes (single to double quotes, line breaks)
packages/tools/src/__tests__/utils.spec.ts Updated import to use new test package name
packages/tools/package.json Added dependency on new test package
packages/test/* New package for vitest functionality
packages/core/* New package for vite core functionality
packages/cli/src/index.ts Refactored to re-export from core and test packages
packages/cli/src/resolve-*.ts Updated resolution logic to use new package structure
packages/cli/package.json Simplified dependencies to use new split packages
packages/cli/build.ts Simplified build to use TypeScript compiler instead of bundling
Various test/config files Formatting changes (single to double quotes)
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)

pnpm-workspace.yaml:1

  • The tsdown version 0.16.6 should be verified. Based on the context, version 0.16.5 was previously used without the caret, and 0.16.0 appears in devDependencies. Ensure version 0.16.6 exists and is the intended version.
    packages/cli/src/resolve-vite.ts:1
  • The binPath construction appears incorrect. The resolve function returns the path to the package's main export, and taking dirname would give the dist directory. The path should likely be join(vitePackagePath, 'dist/vite/node/cli.js') or similar, based on the package structure shown in the build files.
    packages/cli/src/resolve-test.ts:1
  • The binPath construction is inconsistent with the test package structure. According to the test package.json, the bin is at ./vitest.mjs, not dist/cli.js. This should be verified against the actual package structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/cli/src/resolve-test.ts Outdated
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from 3c921f4 to 3f3dd03 Compare November 25, 2025 06:25
Copilot AI review requested due to automatic review settings November 25, 2025 06:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 56 out of 62 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from 0b8969f to db08af5 Compare November 25, 2025 06:48
Copilot AI review requested due to automatic review settings November 25, 2025 06:59
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from db08af5 to e6114b3 Compare November 25, 2025 06:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 56 out of 62 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/src/resolve-vite.ts
Comment thread packages/cli/src/resolve-lib.ts
Comment thread packages/cli/src/bin.ts
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from e6114b3 to 8a4b371 Compare November 25, 2025 07:23
Copilot AI review requested due to automatic review settings November 25, 2025 07:54
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from 8a4b371 to bde4bae Compare November 25, 2025 07:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 59 out of 65 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from bde4bae to ad14e96 Compare November 25, 2025 09:02
Copilot AI review requested due to automatic review settings November 25, 2025 09:35
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from ad14e96 to a43fb94 Compare November 25, 2025 09:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 59 out of 65 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

pnpm-workspace.yaml:1

  • The vitest version ^4.0.13 does not exist. As of January 2025, Vitest's latest major version is 2.x. Version 4.0.13 appears to be a future version that doesn't exist yet. This should be updated to a valid version constraint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/src/resolve-test.ts
Comment thread packages/cli/src/resolve-vite.ts
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from a43fb94 to b3ac106 Compare November 25, 2025 10:06
Copilot AI review requested due to automatic review settings November 26, 2025 01:41
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from b3ac106 to 826ac2c Compare November 26, 2025 01:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 60 out of 66 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from 826ac2c to 8a108a2 Compare November 26, 2025 02:15
Copilot AI review requested due to automatic review settings November 26, 2025 05:52
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from 8a108a2 to 511331f Compare November 26, 2025 05:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 60 out of 66 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from 511331f to bb56d69 Compare November 26, 2025 06:10
Copilot AI review requested due to automatic review settings November 26, 2025 06:44
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from bb56d69 to 2cab8a6 Compare November 26, 2025 06:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 61 out of 67 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from 2cab8a6 to def7164 Compare November 26, 2025 07:13
Copilot AI review requested due to automatic review settings November 26, 2025 08:11
@Brooooooklyn Brooooooklyn force-pushed the 11-25-build_split_vite_plus_core_and_test branch from def7164 to dcd21cd Compare November 26, 2025 08:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 61 out of 67 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Brooooooklyn commented Nov 26, 2025

Copy link
Copy Markdown
Member Author

Merge activity

  • Nov 26, 9:39 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Nov 26, 9:39 AM UTC: @Brooooooklyn merged this pull request with Graphite.

@Brooooooklyn Brooooooklyn merged commit 77e867b into main Nov 26, 2025
22 of 23 checks passed
@Brooooooklyn Brooooooklyn deleted the 11-25-build_split_vite_plus_core_and_test branch November 26, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants