build: split vite plus core and test#319
Conversation
There was a problem hiding this comment.
Pull request overview
This PR restructures the vite-plus monorepo by splitting the core vite and vitest functionality into separate packages (@voidzero-dev/vite-plus-core and @voidzero-dev/vite-plus-test), while the CLI package (@voidzero-dev/vite-plus) now serves as a thin wrapper that re-exports from these packages.
Key changes:
- Split vite functionality into
@voidzero-dev/vite-plus-corepackage - Split vitest functionality into
@voidzero-dev/vite-plus-testpackage - Updated CLI to import from and re-export the new packages
- Updated workspace configuration and build processes
Reviewed changes
Copilot reviewed 90 out of 97 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Updated import path from /config to root package |
tsconfig.json |
Added references to new core and test packages |
pnpm-workspace.yaml |
Updated workspace overrides to use new split packages and bumped tsdown version |
packages/tools/src/utils.ts |
Code formatting changes (single to double quotes, line breaks) |
packages/tools/src/__tests__/utils.spec.ts |
Updated import to use new test package name |
packages/tools/package.json |
Added dependency on new test package |
packages/test/* |
New package for vitest functionality |
packages/core/* |
New package for vite core functionality |
packages/cli/src/index.ts |
Refactored to re-export from core and test packages |
packages/cli/src/resolve-*.ts |
Updated resolution logic to use new package structure |
packages/cli/package.json |
Simplified dependencies to use new split packages |
packages/cli/build.ts |
Simplified build to use TypeScript compiler instead of bundling |
| Various test/config files | Formatting changes (single to double quotes) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (3)
pnpm-workspace.yaml:1
- The tsdown version
0.16.6should be verified. Based on the context, version0.16.5was previously used without the caret, and0.16.0appears in devDependencies. Ensure version0.16.6exists and is the intended version.
packages/cli/src/resolve-vite.ts:1 - The binPath construction appears incorrect. The resolve function returns the path to the package's main export, and taking dirname would give the dist directory. The path should likely be
join(vitePackagePath, 'dist/vite/node/cli.js')or similar, based on the package structure shown in the build files.
packages/cli/src/resolve-test.ts:1 - The binPath construction is inconsistent with the test package structure. According to the test package.json, the bin is at
./vitest.mjs, notdist/cli.js. This should be verified against the actual package structure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3c921f4 to
3f3dd03
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 56 out of 62 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0b8969f to
db08af5
Compare
db08af5 to
e6114b3
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 56 out of 62 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e6114b3 to
8a4b371
Compare
8a4b371 to
bde4bae
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 59 out of 65 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bde4bae to
ad14e96
Compare
ad14e96 to
a43fb94
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 59 out of 65 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
pnpm-workspace.yaml:1
- The vitest version
^4.0.13does not exist. As of January 2025, Vitest's latest major version is 2.x. Version 4.0.13 appears to be a future version that doesn't exist yet. This should be updated to a valid version constraint.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a43fb94 to
b3ac106
Compare
b3ac106 to
826ac2c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 60 out of 66 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
826ac2c to
8a108a2
Compare
8a108a2 to
511331f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 60 out of 66 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
511331f to
bb56d69
Compare
bb56d69 to
2cab8a6
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 61 out of 67 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2cab8a6 to
def7164
Compare
def7164 to
dcd21cd
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 61 out of 67 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|

No description provided.