Skip to content

fix(cli): export additional vitest values from cli package#334

Merged
fengmk2 merged 1 commit into
mainfrom
12-04-fix_cli_more_exports_from_vitest
Dec 4, 2025
Merged

fix(cli): export additional vitest values from cli package#334
fengmk2 merged 1 commit into
mainfrom
12-04-fix_cli_more_exports_from_vitest

Conversation

@fengmk2

@fengmk2 fengmk2 commented Dec 4, 2025

Copy link
Copy Markdown
Member

TL;DR

Added missing Vitest exports to the CLI package to ensure API stability.

What changed?

  • Added exports for configDefaults, coverageConfigDefaults, defaultExclude, defaultInclude, defaultBrowserPort, and defineProject from @voidzero-dev/vite-plus-test/config in the CLI package
  • Added a test file to verify that these exports are properly defined and accessible
  • Added a TODO comment to track the need to keep exports in sync with Vitest

How to test?

Run the newly added test to verify that all exports are properly defined:

pnpm test packages/cli/src/__tests__/index.spec.ts

Why make this change?

This change ensures API stability by exposing all necessary Vitest exports through the CLI package. Users who import these values from the CLI package will now have access to the complete set of configuration utilities, making the API more consistent and comprehensive.

@fengmk2 fengmk2 requested a review from Brooooooklyn December 4, 2025 05:53

fengmk2 commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 changed the title fix(cli): more exports from vitest fix(cli): export additional vitest values from cli package Dec 4, 2025
@fengmk2 fengmk2 marked this pull request as ready for review December 4, 2025 05:54
Copilot AI review requested due to automatic review settings December 4, 2025 05:54
@fengmk2 fengmk2 self-assigned this Dec 4, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds missing Vitest configuration exports to the CLI package to ensure complete API coverage and stability. The change enables users to access important Vitest configuration utilities (like configDefaults, coverageConfigDefaults, and defineProject) directly from the CLI package rather than importing them from the underlying test package.

Key Changes

  • Exported six additional Vitest configuration values from @voidzero-dev/vite-plus-test/config
  • Added a test file to verify the exported values are accessible and properly defined

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/cli/src/index.ts Added exports for configDefaults, coverageConfigDefaults, defaultExclude, defaultInclude, defaultBrowserPort, and defineProject from the test config module with a TODO comment about maintaining sync with Vitest
packages/cli/src/tests/index.spec.ts Added new test file to verify that the exported Vitest configuration values are properly defined and accessible

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cli/src/index.ts
Comment thread packages/cli/src/__tests__/index.spec.ts

fengmk2 commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

@fengmk2 fengmk2 merged commit 5f8edc2 into main Dec 4, 2025
35 of 36 checks passed

fengmk2 commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

Merge activity

@fengmk2 fengmk2 deleted the 12-04-fix_cli_more_exports_from_vitest branch December 4, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants