feat: replace dependencies loaded from CDN with local bundle#9
Open
mariobuikhuizen wants to merge 1 commit intomasterfrom
Open
feat: replace dependencies loaded from CDN with local bundle#9mariobuikhuizen wants to merge 1 commit intomasterfrom
mariobuikhuizen wants to merge 1 commit intomasterfrom
Conversation
Member
|
I thought of just copying the files from the CDN for simplicity, for voila-materialui we have no choice I guess right? What are the cons and pros? |
Member
Author
|
That's what I started with initially, only to find out that the material-design-icons and the roboto font use server side logic and also request other URL's See: https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900|Material+Icons. |
mariobuikhuizen
force-pushed
the
master
branch
from
c59a31c to
d280dd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.