Send execution requests from frontend in progressive rendering mode#1544
Open
trungleduc wants to merge 8 commits intovoila-dashboards:mainfrom
Open
Send execution requests from frontend in progressive rendering mode#1544trungleduc wants to merge 8 commits intovoila-dashboards:mainfrom
trungleduc wants to merge 8 commits intovoila-dashboards:mainfrom
Conversation
Contributor
d8a7d43 to
038da96
Compare
for more information, see https://pre-commit.ci
facb9c6 to
19b7187
Compare
Member
Author
|
Due to the breaking change, this feature should be released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
This PR refactors progressive rendering in Voilà, enabling the frontend to dispatch cell execution requests incrementally via the Jupyter kernel websocket API instead of a custom execution request endpoint
Notebook cell execution is now fully compatible with the Jupyter kernel API, reducing reliance on Voilà-specific server endpoints and the
nbconvertexecution mechanism. As a by-product, Rendering stuck randomly #1428 is fixed in the new progressive rendering modevl22.mp4
Code changes
Frontend
Backend
ExecutionRequestHandleris removed. Instead, progressive rendering is now handled via the standard kernel websocket handler (VoilaKernelWebsocketHandler).execute_requestmessages, replaces the code payload (which is the cell index) with the actual notebook cell source, and passes the message to the Jupyter kernel.User-facing changes
N/A
Backwards-incompatible changes
/voila/execution/is removed/api/kernels/and/api/kernels/%s/channelsare scoped under the/voila/prefix and become/voila/api/kernelsand/voila/kernels/%s/channels