Skip to content

Use BaseException instead of Exception to catch GeneratorExit failures #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SylvainCorlay wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use BaseException instead of Exception to catch GeneratorExit failures #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion voila/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ async def _jinja_cell_generator(self, nb, kernel_id):
self.executor.strip_code_cell_errors(input_cell)
output_cell = input_cell
break
except Exception as e:
except BaseException as e:
self.log.exception('Error at server while executing cell: %r', input_cell)
output_cell = nbformat.v4.new_code_cell()
if self.executor.should_strip_error():
Expand Down