Feature: Rewrite lines by mudream4869 · Pull Request #7 · voilelab/gonovelmaker

mudream4869 · 2026-01-06T14:44:29Z

No description provided.

…hapter files

…d context handling ✨ feat(rewrite): enhance rewrite prompt template with improved formatting ✨ feat(cli): add line range and context options to CLI command builder ✨ style: add styles for rewrite confirmation modal and text display

…d modal

… and context extraction

…p imports

Copilot

Pull request overview

This PR adds a "rewrite lines" feature that allows users to select text in their Obsidian vault and have it rewritten by an AI model with specific goals (e.g., removing AI-like phrases). The feature integrates with both the Obsidian plugin frontend and the Go CLI backend.

Key changes:

Adds a new rewrite command accessible from the Obsidian editor that prompts for rewrite goals, sends the selected text to the AI with surrounding context, and displays a confirmation modal with before/after comparison
Implements Go CLI backend support including line extraction with context, template-based prompt generation, and both JSON (for plugin use) and direct file modification modes
Includes validation tests, CSS styling for the confirmation modal, and updates to the config check command

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
obsidian-novelmaker/styles.css	Adds CSS styling for the rewrite confirmation modal, including text boxes, section headers, and usage info display
obsidian-novelmaker/src/utils/cli.js	Extends CLI command builder to support new rewrite-specific options (line ranges, context windows, prompt goal)
obsidian-novelmaker/src/modals/rewrite-prompt.js	New modal for collecting the rewrite goal/instruction from the user
obsidian-novelmaker/src/modals/rewrite-confirm.js	New modal displaying before/after comparison and applying the rewrite to the editor
obsidian-novelmaker/src/commands/rewrite.js	Command registration and execution logic for the rewrite feature, handling text selection and modal flow
obsidian-novelmaker/main.js	Registers the rewrite command with the plugin
novelmaker/struct.go	Adds RewritePrompt struct to hold template configuration
novelmaker/render.go	Implements RenderRewrite function to execute AI rewriting with context and goal
internal/obsidian/vault.go	Adds LoadRewritePrompt method to read and parse the rewrite prompt template
internal/obsidian/init_template/Config/rewrite_prompt.md	Default template for rewrite prompts with system instructions and context structure
cmd/novelmaker-obs/main.go	Integrates rewrite command into the CLI root command
cmd/novelmaker-obs/cmd_rewrite_test.go	Unit tests for validation logic and file reading functionality
cmd/novelmaker-obs/cmd_rewrite.go	Full CLI implementation including argument parsing, line extraction, context building, and file modification
cmd/novelmaker-obs/cmd_config_check.go	Updates config check to validate the new rewrite prompt template

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cmd/novelmaker-obs/cmd_rewrite.go

Copilot · 2026-01-06T14:49:48Z

obsidian-novelmaker/src/utils/cli.js

+	if (options.promptGoal && options.promptGoal.trim()) {
+		args.push('--prompt', options.promptGoal);
+	}


Both options.prompt (line 78-80) and options.promptGoal (line 82-84) are being mapped to the same CLI flag --prompt. If both options are provided simultaneously, this will result in duplicate --prompt arguments being passed to the CLI command. While the rewrite command uses promptGoal and other commands use prompt, this creates potential for confusion and bugs if the function is called with both options set.

Consider either:

Renaming the flag in the Go CLI to match the JavaScript property name (e.g., use --prompt-goal for rewrite commands)

Making these conditions mutually exclusive with an early check

Using different flag names for different command types

Copilot · 2026-01-06T14:49:48Z

obsidian-novelmaker/src/modals/rewrite-confirm.js

+		// Get current document content
+		const doc = this.editor.getDoc();
+


The variable doc is declared but never used. The getDoc() call appears to be unnecessary since replaceRange() is called directly on this.editor without using the doc variable. This line can be safely removed.

Suggested change

// Get current document content

const doc = this.editor.getDoc();

Copilot · 2026-01-06T14:49:49Z

obsidian-novelmaker/src/commands/rewrite.js

+	try {
+		// Default context lines
+		const contextPrev = 3;
+		const contextNext = 3;
+
+		const loadingModal = new LoadingModal(plugin.app, '正在改寫文字...請稍候');
+		loadingModal.open();
+
+		try {
+			const vaultPath = plugin.app.vault.adapter.basePath;
+
+			const args = buildCLICommand('rewrite', {
+				json: true,
+				filepath: file.path,
+				lineStart,
+				lineEnd,
+				contextPrev,
+				contextNext,
+				promptGoal,
+				backend: plugin.settings.backend,
+				timeout: plugin.settings.timeout,
+			});
+
+			const { stdout } = await executeCLI(plugin, plugin.settings.cliPath, args, vaultPath);
+			const output = parseJSONOutput(stdout);
+
+			// Show confirmation modal with before/after comparison
+			new RewriteConfirmModal(
+				plugin.app,
+				editor,
+				file,
+				selectedText,
+				output.rewritten_content,
+				lineStart,
+				lineEnd,
+				output
+			).open();
+
+		} catch (error) {
+			new Notice(`❌ 錯誤: ${error.message}`);
+			console.error(error);
+		} finally {
+			loadingModal.forceCloseNow();
+		}
+
+	} catch (error) {
+		new Notice(`❌ 錯誤: ${error.message}`);
+		console.error(error);


There are nested try-catch blocks with identical error handling logic. The outer try-catch (lines 54-102) wraps an inner try-catch (lines 62-97), but both handle errors the same way by showing a Notice and logging to console. The outer try-catch is redundant and should be removed to simplify the error handling flow.

Suggested change

try {

// Default context lines

const contextPrev = 3;

const contextNext = 3;

const loadingModal = new LoadingModal(plugin.app, '正在改寫文字...請稍候');

loadingModal.open();

try {

const vaultPath = plugin.app.vault.adapter.basePath;

const args = buildCLICommand('rewrite', {

json: true,

filepath: file.path,

lineStart,

lineEnd,

contextPrev,

contextNext,

promptGoal,

backend: plugin.settings.backend,

timeout: plugin.settings.timeout,

});

const { stdout } = await executeCLI(plugin, plugin.settings.cliPath, args, vaultPath);

const output = parseJSONOutput(stdout);

// Show confirmation modal with before/after comparison

new RewriteConfirmModal(

plugin.app,

editor,

file,

selectedText,

output.rewritten_content,

lineStart,

lineEnd,

output

).open();

} catch (error) {

new Notice(`❌ 錯誤: ${error.message}`);

console.error(error);

} finally {

loadingModal.forceCloseNow();

}

} catch (error) {

new Notice(`❌ 錯誤: ${error.message}`);

console.error(error);

// Default context lines

const contextPrev = 3;

const contextNext = 3;

const loadingModal = new LoadingModal(plugin.app, '正在改寫文字...請稍候');

loadingModal.open();

try {

const vaultPath = plugin.app.vault.adapter.basePath;

const args = buildCLICommand('rewrite', {

json: true,

filepath: file.path,

lineStart,

lineEnd,

contextPrev,

contextNext,

promptGoal,

backend: plugin.settings.backend,

timeout: plugin.settings.timeout,

});

const { stdout } = await executeCLI(plugin, plugin.settings.cliPath, args, vaultPath);

const output = parseJSONOutput(stdout);

// Show confirmation modal with before/after comparison

new RewriteConfirmModal(

plugin.app,

editor,

file,

selectedText,

output.rewritten_content,

lineStart,

lineEnd,

output

).open();

} catch (error) {

new Notice(`❌ 錯誤: ${error.message}`);

console.error(error);

} finally {

loadingModal.forceCloseNow();

Copilot · 2026-01-06T14:49:49Z

obsidian-novelmaker/styles.css

+.rewrite-before h3 {
+	color: var(--text-muted);
+}
+
+.rewrite-after h3 {


The CSS selectors .rewrite-before h3 (line 212) and .rewrite-after h3 (line 216) assume the h3 elements are children of the div elements. However, in the JavaScript code (rewrite-confirm.js lines 30-35, 38-43), the h3 elements are created as siblings directly under contentEl, not as children of the beforeDiv and afterDiv. This means these CSS rules will never match and the h3 color styling will not be applied.

To fix this, either:

Move the h3 creation inside the respective divs in the JavaScript

Change the CSS selectors to target the h3 elements differently (e.g., using adjacent sibling selectors or different class names)

Suggested change

.rewrite-before h3 {

color: var(--text-muted);

}

.rewrite-after h3 {

.rewrite-before {

color: var(--text-muted);

}

.rewrite-after {

cmd/novelmaker-obs/cmd_rewrite.go

novelmaker/render.go

…e process

mudream4869 added 7 commits January 5, 2026 21:37

✨ feat(rewrite): add rewrite prompt template and parsing functionality

9d1c2cb

✨ feat(rewrite): add rewrite command for AI-based line rewriting in c…

88a44bc

…hapter files

✨ feat(rewrite): add prompt goal functionality for rewrite command an…

856267d

…d modal

✨ feat(tests): add comprehensive tests for rewrite command validation…

88a4c92

… and context extraction

🧹 refactor(cmd_rewrite): remove min/max

584e8ad

🧹 refactor(tests): remove unused context extraction tests and clean u…

b5aba81

…p imports

mudream4869 requested a review from Copilot January 6, 2026 14:44

Copilot started reviewing on behalf of mudream4869 January 6, 2026 14:45 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

mudream4869 added 2 commits January 6, 2026 23:30

🔧 refactor(render): remove project parameter from RenderRewrite function

994ecfd

📝 docs(cmd_rewrite): update command description to clarify file updat…

41cab33

…e process

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Rewrite lines#7

Feature: Rewrite lines#7
mudream4869 wants to merge 9 commits intostagingfrom
rewrite_prompt

mudream4869 commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Copilot AI Jan 6, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// Get current document content
		const doc = this.editor.getDoc();

Conversation

mudream4869 commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants