NOJIRA-Remove-legacy-contact-interaction-code - #1138
Merged
Conversation
Follow-up cleanup for PR #1137 (contact_interactions -> peer_events retirement). The handler/RPC/subscription layers were already cleaned up there; this removes what design doc §2.4/§3.6 explicitly deferred to a follow-up: the now-unreachable models and dbhandler layer, plus the underlying MySQL tables. - bin-contact-manager: delete models/interaction, models/resolution packages entirely - bin-contact-manager: delete pkg/dbhandler/interaction.go (Create/Get/ List/ListByOwnershipPeriods/ListByIDs/ListUnresolved) and resolution.go (Create/CreateTx/Delete/ListByInteraction/ListByContact) - bin-contact-manager: delete pkg/dbhandler/address_ownership_read.go's OwnershipPeriodsListByContactID/MissingPeriodOwnedAddresses -- these existed solely to support the old InteractionList's ownership-period matching (per their own doc comments); the write path (OwnershipPeriodsLockAndResolveTx, used by live Address CRUD) is untouched - bin-contact-manager: remove the 9 corresponding DBHandler interface methods, regenerate mocks - bin-contact-manager: rewrite pkg/casehandler/casenote_isolation_test.go for the post-PR-#1137 world -- InteractionList no longer queries any local table, so the isolation guarantee is now structural (CaseNoteCreate must never call any RequestHandler RPC, proven via gomock strict mode on a RequestHandler mock with zero EXPECT() calls configured) - bin-contact-manager: drop the SQLite contact_interactions/ contact_resolutions test-fixture tables from scripts/database_scripts_test/contacts.sql - bin-dbscheme-manager: add migration d8b04ef3ddd0 dropping the contact_interactions/contact_resolutions MySQL tables in production. contact_address_ownership_periods is explicitly NOT touched -- it is still live, used by Address CRUD independent of Interaction
Round 2 PR review finding. - bin-dbscheme-manager: contact_interactions/contact_resolutions rows removed from docs/schema-ownership.md, matching precedent set by PR #1089 (NOJIRA-remove-dead-legacy-contact-tables) for keeping this doc in sync with table drops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup for PR #1137 (contact_interactions -> peer_events retirement, design doc bin-contact-manager/docs/plans/2026-07-25-contact-interaction-retire-to-peer-events-design.md). That PR cleaned the handler/RPC/subscription layers; this removes what design doc §2.4/§3.6 explicitly deferred to a follow-up -- the now-unreachable models/dbhandler layer and the underlying MySQL tables.