NOJIRA-fix-flaky-receive-message-context-canceled-test - #1140
Merged
pchero merged 1 commit intoJul 25, 2026
Conversation
Fix a data race in zmqsubhandler.receiveMessage that made Test_recevieMessage_context_canceled fail intermittently under go test -race (and occasionally without -race, when scheduling happened to line up the same way). - bin-api-manager: receiveMessage now selects on ctx.Done() while waiting to retry after EAGAIN, instead of an unconditional time.Sleep(1s). Previously a canceled context could go unnoticed for up to 1 second, racing with callers that Terminate() the zmq socket shortly after cancel(). - bin-api-manager: Test_recevieMessage_context_canceled now waits on a done channel for the receiveMessage goroutine to actually return after cancel(), instead of a fixed 1s sleep, before the deferred sockSub.Terminate() runs.
pchero
deleted the
NOJIRA-fix-flaky-receive-message-context-canceled-test
branch
July 25, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a data race in zmqsubhandler.receiveMessage that made Test_recevieMessage_context_canceled fail intermittently under go test -race (and occasionally without -race, when scheduling happened to line up the same way).