NOJIRA-Fix-openapi-manager-vendor-sync - #1146
Merged
Merged
Conversation
- bin-openapi-manager: Bump oapi-codegen from v2.7.1 to v2.8.0 in go.mod/go.sum to match the version actually used to generate the committed gens/models/gen.go. go.mod was pinned to v2.7.1 while gen.go was generated with v2.8.0, so `go generate ./...` in CI regenerated with v2.7.1 and produced a diff (stripped Example comments, unprefixed enum constant names) that failed the "Verify generated models match committed" CircleCI check.
- bin-openapi-manager: Add .github/dependabot.yml ignoring the oapi-codegen dependency so future Dependabot version/security updates cannot re-drift go.mod away from the version that generated the committed gens/models/gen.go, which is what caused this PR's underlying CI failure (introduced by #1145's automated dependency sweep).
- bin-openapi-manager: Fix dependabot.yml comment that incorrectly claimed the ignore rule covers Dependabot security-update PRs. ignore and open-pull-requests-limit only govern scheduled version-update PRs; security-update PRs are gated separately by the repo's Dependabot security updates toggle (currently disabled). Comment now states this accurately and flags it as something to revisit if that toggle is ever enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a version mismatch between go.mod and the committed generated models in bin-openapi-manager that was causing the CircleCI "Verify generated models match committed" check to fail, and prevent the same class of drift from recurring via automated dependency updates.