VOIP-1276-Replace-api-manager-zmq-with-pure-go-pubsub - #1150
Merged
pchero merged 1 commit intoJul 31, 2026
Conversation
- bin-api-manager: Add pkg/pubsubhandler, a pure Go in-process pub/sub broker replacing ZeroMQ - bin-api-manager: Preserve ZMQ behavioral contract (prefix matching, deliver-once, drop-on-full with metric, buffer 2000) - bin-api-manager: Race-free shutdown design (never-closed data channel + done signal, unregister under write lock) - bin-api-manager: Wire broker via constructor injection in cmd/api-manager/main.go, subscribehandler, websockhandler - bin-api-manager: Remove pkg/zmq, pkg/zmqpubhandler, pkg/zmqsubhandler and pebbe/zmq4 cgo dependency - bin-api-manager: Remove libzmq install steps from Dockerfile, README, CLAUDE.md, docs - bin-api-manager: Add design document docs/plans/2026-07-31-api-manager-pubsub-replacement-design.md - monorepo: Remove libzmq install step from CircleCI config and development guide - monorepo: Update root CLAUDE.md event-driven architecture description
pchero
force-pushed
the
VOIP-1276-Replace-api-manager-zmq-with-pure-go-pubsub
branch
from
July 31, 2026 00:14
fa476b9 to
43e3b75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bin-api-manager's internal ZeroMQ (pebbe/zmq4, cgo) pub/sub with a pure Go in-process broker. The only ZeroMQ transport in use was inproc://api-manager (pod-local fan-out of RabbitMQ events to WebSocket subscribers), so the cgo/libzmq dependency bought nothing. The replacement preserves the full behavioral contract (topic prefix matching, deliver-once on overlapping prefixes, drop-on-full slow-subscriber isolation with a new drop counter metric, buffer 2000 matching the previous effective HWM) and fixes latent data races from concurrent use of non-thread-safe libzmq sockets, plus removes the 1-second receive polling latency. Jira: VOIP-1276.