VOIP-1315-Fix-talk-chat-leave-500-error - #1183
Merged
Merged
Conversation
- bin-api-manager: Fix nil pointer panic in ServiceAgentTalkParticipantDelete when the talk-manager backend replies 204 No Content on successful participant removal - bin-api-manager: Add regression tests covering the 204/nil success path, the 200/body success path, and the permission-denied path for participant delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Talk 채팅방 leave(참가자 삭제) 시 100% 재현되던 500 에러를 수정한다. talk-manager 백엔드가 성공 시 항상 204 No Content만 반환하는데, 이를 소비하는 bin-api-manager 쪽에서 nil 체크 없이 결과를 바로 사용해 nil pointer dereference panic이 발생했다. VOIP-1315.