Corrected some small errors in the bounds files#13
Open
rohan3412 wants to merge 6 commits intovolBrain:mainfrom
Open
Corrected some small errors in the bounds files#13rohan3412 wants to merge 6 commits intovolBrain:mainfrom
rohan3412 wants to merge 6 commits intovolBrain:mainfrom
Conversation
added "total", "right", "left", and "asym" strings to limbic cortex, insular cortex, and cerebrum gm
added "total", "right", "left", and "asym" strings to limbic cortex, insular cortex, and cerebrum gm
added "total", "right", "left", and "asym" strings to limbic cortex, insular cortex, and cerebrum gm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brain Region names in bounds_male.csv, bounds_female.csv and bounds_general.csv, have an inappropriate and confusing prefix
eg:
Left ventral DC_total
Left ventral DC_right
Left ventral DC_left
Left ventral DC_asym
Frontal lobe_total
Frontal lobe_right
Frontal lobe_left
Frontal lobe_asym
Left sup. frontal gyrus_total
Left sup. frontal gyrus_right
Left sup. frontal gyrus_left
Left sup. frontal gyrus_asym
Frontal lobe format is fine, but ventral DC, and sup. frontal gyrus have prefixes of 'Left ', which is not accurate as the alternate direction ('Right ') prefix for these brain regions are not in the csv files, and the actual left or right, and total values are present and specified by the postfix '_left' and '_right'.
In the pull request, this unnecessary prefix is removed, as well as the inconsistent underscores.
OLD:
NEW:
