Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): don't send data to client if LanguageServicePlugin do not support resolve #233

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

johnsoncodehk
Copy link
Member

Some plugins like volar-service-css, volar-service-html do not support completion item resolve, so there is no need to set data for completion item, which can reduce LSP traffic.

Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: 8a492eb

@volar/eslint

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/eslint@233

@volar/jsdelivr

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/jsdelivr@233

@volar/kit

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/kit@233

@volar/language-core

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-core@233

@volar/language-server

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-server@233

@volar/language-service

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/language-service@233

@volar/monaco

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/monaco@233

@volar/source-map

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/source-map@233

@volar/test-utils

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/test-utils@233

@volar/typescript

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/typescript@233

@volar/vscode

pnpm add https://pkg.pr.new/volarjs/volar.js/@volar/vscode@233

Open in Stackblitz

@johnsoncodehk johnsoncodehk merged commit 7e8bc50 into master Aug 25, 2024
9 checks passed
@johnsoncodehk johnsoncodehk deleted the remove-item-data branch August 25, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant