1780 dlllist loadcount missing #1781
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikelos
reviewed
Apr 17, 2025
| except Exception: | ||
| LoadCount = None | ||
| if LoadCount == 65535: | ||
| LoadCount = -1 |
There was a problem hiding this comment.
Is this a valid situation, or should this also return None as a means of error?
There was a problem hiding this comment.
If it's supposed to be signed, you could .cast('CORRECT_TYPE') it to the right type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the LoadCount column with a symbol extension since it depends on OS version.
@ikelos Not sure if there's a better way of printing the -1. the actual data is a signed short as 0xffff.
Also would this need a version bump and if so which number?