-
Notifications
You must be signed in to change notification settings - Fork 103
implemented a CI check to validate code generation #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
katara-Jayprakash
wants to merge
10
commits into
volcano-sh:master
Choose a base branch
from
katara-Jayprakash:feature/add-ci-workflows
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
015ead5
ci: add API validation and code generation workflows
katara-Jayprakash 8f3e5e8
add Makefile
katara-Jayprakash 68dc4a1
deps: update dependencies for CI tools
katara-Jayprakash c737989
refactor: remove unused generate-internal-groups script
katara-Jayprakash 6f44c9f
ci: fix codegen script execution permission
katara-Jayprakash ea7435d
Removing api-structure from workflow
katara-Jayprakash 29baf97
adding crdify and synced go-mod and go-sum with volcano-repo
katara-Jayprakash 73f8644
removing unwanted from makefiles
katara-Jayprakash f4a4fe0
removing things
katara-Jayprakash f4868b2
removing api
katara-Jayprakash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: API Check | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "pkg/apis/**" | ||
|
|
||
| jobs: | ||
| api-check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: "go.mod" | ||
|
|
||
| - name: Run go vet | ||
| run: go vet ./pkg/apis/... | ||
|
|
||
| - name: Check formatting | ||
| run: test -z "$(gofmt -l pkg/apis/)" | ||
|
|
||
| - name: Install API linter | ||
| run: go install sigs.k8s.io/kube-api-linter/cmd/golangci-lint-kube-api-linter@latest | ||
|
|
||
| - name: Run API linter | ||
| run: ~/go/bin/golangci-lint-kube-api-linter run ./pkg/apis/... | ||
| continue-on-error: true | ||
|
|
||
| - name: Install crdify | ||
| run: go install sigs.k8s.io/crdify@latest | ||
|
katara-Jayprakash marked this conversation as resolved.
Outdated
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: Code Generation Check | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'pkg/apis/**' | ||
| - 'hack/**' | ||
|
|
||
| jobs: | ||
| verify-codegen: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version-file: 'go.mod' | ||
| - run: bash hack/verify-codegen.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| update-codegen: | ||
| ./hack/update-codegen.sh | ||
|
|
||
| verify-codegen: | ||
| ./hack/verify-codegen.sh | ||
|
|
||
| api-lint: | ||
|
katara-Jayprakash marked this conversation as resolved.
Outdated
|
||
| go vet ./pkg/apis/... | ||
| test -z "$$(gofmt -l pkg/apis/)" | ||
|
|
||
| crd-gen: | ||
| @echo "Validating API structure with crdify..." | ||
| go install sigs.k8s.io/crdify@latest | ||
| ~/go/bin/crdify --help || echo "crdify installed" | ||
|
katara-Jayprakash marked this conversation as resolved.
Outdated
|
||
|
|
||
| build: | ||
| go build ./... | ||
|
|
||
| test: | ||
| go test ./... | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.