CI Github action work flow#171
Conversation
Signed-off-by: jayesh@9747 <112215167@cse.iiitp.ac.in>
|
Welcome @jayesh9747! |
Signed-off-by: jayesh@9747 <112215167@cse.iiitp.ac.in>
Signed-off-by: jayesh@9747 <112215167@cse.iiitp.ac.in>
Signed-off-by: jayesh@9747 <112215167@cse.iiitp.ac.in>
|
/assign @Monokaix |
|
We already have format check ci in https://github.com/volcano-sh/dashboard/blob/main/.github/workflows/formatting.yml, maybe we can add build check ci for both frontend and backend. |
.github/workflows/ci.yml
Outdated
| if: success() | ||
| run: echo "Frontend server started successfully ✅" | ||
|
|
||
| backend: |
There was a problem hiding this comment.
IMO, we don't have to emphasize to seperate frontend and backend, just focus on build/test for both of them.
Signed-off-by: jayesh@9747 <112215167@cse.iiitp.ac.in>
| } | ||
| } | ||
| ] | ||
| rules: [ |
There was a problem hiding this comment.
Should we also ignore document?
There was a problem hiding this comment.
could you explain furthure , i can't get it.
There was a problem hiding this comment.
I mean we don't have to format .md files, and just ignore them is ok.
|
Please also add docker image build check in build.yaml, ref: https://github.com/volcano-sh/dashboard/blob/main/CONTRIBUTING.md#inside-kubernetes-cluster |
Signed-off-by: Alivestars24 <vaishnavimandhani2@gmail.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
1 similar comment
|
/lgtm |
5 participants
PR Description: Add CI Jobs for Frontend & Backend
This PR adds automated CI jobs for both the frontend and backend to improve code quality and reliability. The following checks have been included: Frontend & Backend Jobs
These steps help maintain a clean and stable codebase across all areas of the application.