-
Notifications
You must be signed in to change notification settings - Fork 44
fix issue75: seg fault and listen volcano.sock fail #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @linuxfhy! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @william-wang |
related issue: #75 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request addresses issue75 by improving error handling around the socket listen setup and adjusting the client usage in the allocation process.
- In the Serve function, the code now attempts to remove the existing socket file and retry listening when net.Listen fails.
- In the Allocate function, the invocation of util.UseClient has been relocated to ensure proper initialization before proceeding with candidate pod evaluation.
Comments suppressed due to low confidence (1)
pkg/plugin/nvidia/server.go:192
- Consider verifying that the error is due to an existing socket (e.g., EADDRINUSE) before removing the file to avoid inadvertently deleting an unrelated file.
log.Printf("Listen sock fail and retry for '%s': %s", m.resourceName, err)
util.UseClient(m.kubeInteractor.clientset) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the relocation of util.UseClient here is intentional and that omitting its call at the original location does not lead to any side effects or missed initialization.
util.UseClient(m.kubeInteractor.clientset) |
Copilot uses AI. Check for mistakes.
No description provided.