Skip to content

Fix type issue #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sailorvii wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type issue #376

sailorvii wants to merge 1 commit into from

Conversation

@sailorvii
Copy link

@sailorvii sailorvii commented Apr 27, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    /kind documentation

-->

  • What this PR does / why we need it:

  • Which issue(s) this PR fixes:

  • A type issue

@volcano-sh-bot
Copy link
Collaborator

volcano-sh-bot commented Apr 27, 2025

Welcome @sailorvii!

It looks like this is your first PR to volcano-sh/website.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only kind/documentation Categorizes issue or PR as related to documentation. labels Apr 27, 2025
@volcano-sh-bot
Copy link
Collaborator

volcano-sh-bot commented Apr 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign thor-wl
You can assign the PR to them by writing /assign @thor-wl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 27, 2025
Fix type issue
43b5cb4 
Signed-off-by: chenw66 <[email protected]>
Arhell
Arhell reviewed Apr 27, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2025
@Arhell Arhell removed their assignment Apr 27, 2025
@Monokaix
Copy link
Member

Monokaix commented Jun 30, 2025

@kevin-wangzefeng @william-wang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@william-wang william-wang Awaiting requested review from william-wang

1 more reviewer

@Arhell Arhell Arhell left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sailorvii @volcano-sh-bot @Monokaix @Arhell