Skip to content

Conversation

@Niyatizzz
Copy link

@Niyatizzz Niyatizzz commented Jun 3, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    /kind design
    /kind cleanup
  • What this PR does / why we need it:
    hi, this pr resolves the dark-mode feature which was already present in the params but could not be implemented due to conflicting hardcoded inline styling and css issues, i have cleaned this up by replacing inline color styles with proper CSS classes ensuring that the .dark class toggles expected elements

  • Which issue(s) this PR fixes:
    fixes issue Feature Request: Add Dark Mode Support #364
    fixes closed pr Added Dark Mode feature #365

@volcano-sh-bot volcano-sh-bot requested review from Thor-wl and k82cn June 3, 2025 03:10
@volcano-sh-bot volcano-sh-bot added kind/design Categorizes issue or PR as related to design. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/bug Categorizes issue or PR as related to a bug. labels Jun 3, 2025
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2025
@Niyatizzz
Copy link
Author

Niyatizzz commented Jun 3, 2025

/assign @k82cn @Monokaix

hi, please review this pr and let me know if any changes are required
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants