-
Notifications
You must be signed in to change notification settings - Fork 81
add architecture and component. #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @bearslyricattack, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the architecture.md documentation file to provide a much more comprehensive and detailed overview of Volcano's system architecture and its various components. The goal is to give users a deeper understanding of how Volcano integrates with Kubernetes and how its core parts work together to manage high-performance workloads. This includes expanded descriptions of existing components like the Scheduler, Controller, Admission, and Vcctl, as well as the introduction of new components such as the Agent for resource monitoring and Network-qos for network bandwidth management. Each component now has dedicated sections detailing its purpose, functionality, and configurable parameters.
Highlights
- Expanded Architecture Overview: The initial architecture overview has been significantly expanded to provide a more comprehensive understanding of Volcano's compatibility with Kubernetes, its design philosophy, and its core components (Scheduler, ControllerManager, Admission, Vcctl). It also introduces the layered architecture and its benefits.
- Detailed Component Descriptions: New sections have been added to describe each major Volcano component in detail: Scheduler, Controller (with its various sub-controllers like gc-controller, job-controller, jobflow-controller, jobtemplate-controller, pg-controller, queue-controller), Admission, Vcctl, Agent, and Network-qos. Each component's role, functionality, and extensive configurable parameters are now documented.
- Introduction of Agent Component: The addition of the 'Agent' component highlights Volcano's capability for resource monitoring and oversubscription management on Kubernetes nodes, aiming to improve cluster resource utilization.
- Introduction of Network-qos Component: The 'Network-qos' component is introduced, detailing its function in intelligently regulating network bandwidth between different types of workloads (online vs. offline) to ensure service quality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly expands the architecture documentation, providing detailed information about Volcano's components and their parameters. The new content is comprehensive and valuable. My review focuses on improving consistency in formatting, naming, and structure to enhance the document's professionalism and readability. Key suggestions include standardizing table formats, ensuring consistent terminology and casing, and improving clarity in some descriptions. Overall, this is a great addition to the documentation.
|
|
||
| #### jobflow-controller | ||
|
|
||
| jobflow-controller主要负责管理和协调 JobFlow CR的生命周期。它通过监听 JobFlow、JobTemplate 和 Job 资源的变化,处理相关事件并维护 JobFlow 的状态。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为了保持术语一致性,建议将控制器名称统一为大写驼峰式(PascalCase),与其他控制器(如 Job Controller、PodGroup Controller)的描述风格保持一致。
例如,jobflow-controller 应描述为 JobFlow Controller。
类似的,第231行的 jobTemplate Controller 也应统一为 JobTemplate Controller。
| jobflow-controller主要负责管理和协调 JobFlow CR的生命周期。它通过监听 JobFlow、JobTemplate 和 Job 资源的变化,处理相关事件并维护 JobFlow 的状态。 | |
| JobFlow Controller 主要负责管理和协调 JobFlow CR 的生命周期。它通过监听 JobFlow、JobTemplate 和 Job 资源的变化,处理相关事件并维护 JobFlow 的状态。 |
content/zh/docs/architecture.md
Outdated
|
|
||
| #### 参数 | ||
|
|
||
| vcctl不需要 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content/zh/docs/architecture.md
Outdated
| #### 介绍 | ||
|
|
||
| Volcano由scheduler、controllermanager、admission和vcctl组成: | ||
| Network插件是一个专为 Kubernetes 集群设计的网络带宽管理解决方案,旨在智能调节不同类型工作负载之间的网络资源分配。该插件通过 CNI 机制与现有网络插件链式组合,实现对容器网络流量的精细控制。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0f03db8 to
d6f45c7
Compare
27b01ea to
95010ae
Compare
e97340f to
4632a80
Compare
Signed-off-by: 抒情熊 <[email protected]>
Signed-off-by: 抒情熊 <[email protected]>
Signed-off-by: 抒情熊 <[email protected]>
Signed-off-by: 抒情熊 <[email protected]>
Signed-off-by: 抒情熊 <[email protected]>
4632a80 to
68832cb
Compare
Signed-off-by: 抒情熊 <[email protected]>
Signed-off-by: 抒情熊 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR significantly expands the architecture documentation for Volcano by adding comprehensive component descriptions and parameter references. The changes replace the previous brief overview with detailed explanations of Volcano's architecture, component responsibilities, and configuration options.
Key changes:
- Updated overview section with expanded architectural description and replaced diagram reference (arch_1.png → arch_3.jpg)
- Added detailed component documentation for Scheduler, Controller, Admission, Vcctl, Agent, and Network-qos components
- Included comprehensive parameter tables for each component with descriptions, defaults, and examples
- Added subsection descriptions for all controller types (gc-controller, job-controller, jobflow-controller, etc.)
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| content/zh/docs/architecture.md | Chinese version of expanded architecture documentation with detailed component parameters and configuration options |
| content/en/docs/architecture.md | English version of expanded architecture documentation with detailed component parameters and configuration options |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Vcctl | ||
| Volcano vcctl是Volcano的命令行客户端工具。 |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old content from the previous version was not properly removed. These lines (278-279) should be deleted as they appear in the middle of the Admission section's parameter tables and are now redundant with the new Vcctl section starting at line 319.
| - Vcctl | |
| Volcano vcctl是Volcano的命令行客户端工具。 |
| | ---------------------- | -------- | ------- | ------------------------------------------------------------ | | ||
| | `--supported-features` | []string | `["*"]` | 支持的特性列表。`*` 表示支持所有默认启用的特性,`foo` 表示支持名为 `foo` 的特性,`-foo` 表示不支持名为 `foo` 的特性 | | ||
|
|
||
| #### Network-qos |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heading hierarchy inconsistency: Network-qos should be at the same level as Agent (###) rather than a subsection of Agent (####). Network-qos is listed as a separate top-level component in line 40, indicating it should have its own ### heading like other main components.
| #### Network-qos | |
| ### Network-qos |
|
|
||
| ##### Introduction | ||
|
|
||
| The Network plugin is a network bandwidth management solution designed specifically for Kubernetes clusters, Used in conjunction with the Agent component,aimed at intelligently adjusting network resource allocation between different types of workloads. This plugin integrates with existing network plugins through the CNI mechanism, enabling fine-grained control over container network traffic. |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after comma. Should be 'Agent component, aimed' instead of 'Agent component,aimed'.
| | ---------------------- | -------- | ------- | ------------------------------------------------------------ | | ||
| | `--supported-features` | []string | `["*"]` | List of supported features. `*` means support all features enabled by default, `foo` means support feature named `foo`, `-foo` means don't support feature named `foo` | | ||
|
|
||
| #### Network-qos |
Copilot
AI
Nov 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heading hierarchy inconsistency: Network-qos should be at the same level as Agent (###) rather than a subsection of Agent (####). Network-qos is listed as a separate top-level component in line 40, indicating it should have its own ### heading like other main components.
| #### Network-qos | |
| ### Network-qos |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes: