Skip to content

Conversation

@suyiiyii
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

/kind documentation

  • What this PR does / why we need it:

  • Which issue(s) this PR fixes:

@volcano-sh-bot
Copy link
Collaborator

Welcome @suyiiyii!

It looks like this is your first PR to volcano-sh/website.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only kind/bug Categorizes issue or PR as related to a bug. labels Sep 19, 2025
@volcano-sh-bot volcano-sh-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. kind/design Categorizes issue or PR as related to design. labels Sep 19, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @suyiiyii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds new documentation for Volcano's Validating Admission Policy (VAP) and Mutating Admission Policy (MAP). The documentation clarifies how these policies enhance resource validation and modification within Volcano, offering detailed guides on their installation via Helm or YAML, configuration, and usage. It also covers essential prerequisites and notes on the interplay between these new policies and existing webhooks, ensuring users can effectively implement and manage them.

Highlights

  • New Admission Policy Documentation: Introduced comprehensive documentation for Volcano's Validating Admission Policy (VAP) and Mutating Admission Policy (MAP), explaining their role in validating and modifying Volcano resources.
  • Installation and Configuration Guidance: Provided detailed instructions on how to enable VAP and MAP during Volcano installation using both Helm and direct YAML manifests, including specific configuration options.
  • Usage and Verification Steps: Included practical steps for users to verify that VAP and MAP are active post-installation and demonstrated how to test validation with an example of an invalid job creation.
  • Prerequisites and Limitations: Outlined the Kubernetes version prerequisites for VAP (1.30+) and MAP (1.32+) and highlighted important notes regarding MAP's partial functionality and its coexistence with existing Volcano webhooks.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 19, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new documentation for Volcano's Validating Admission Policy (VAP) and Mutating Admission Policy (MAP), with versions in both English and Chinese. The documentation is well-structured, clear, and provides good examples for installation and usage. I've provided a few suggestions to enhance clarity and consistency. Specifically, I've recommended making the commands for verifying policy bindings more user-friendly and aligning a heading in the Chinese document with the English version.

@volcano-sh-bot volcano-sh-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 19, 2025
suyiiyii added a commit to suyiiyii/website that referenced this pull request Oct 20, 2025
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 20, 2025
@suyiiyii suyiiyii closed this Oct 20, 2025
@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2025
@suyiiyii suyiiyii reopened this Oct 20, 2025
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign william-wang
You can assign the PR to them by writing /assign @william-wang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2025
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 20, 2025
@kevin-wangzefeng kevin-wangzefeng removed the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. retest-not-required-docs-only size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants