-
Notifications
You must be signed in to change notification settings - Fork 81
Add admission policy documentation #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Welcome @suyiiyii! |
Summary of ChangesHello @suyiiyii, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds new documentation for Volcano's Validating Admission Policy (VAP) and Mutating Admission Policy (MAP). The documentation clarifies how these policies enhance resource validation and modification within Volcano, offering detailed guides on their installation via Helm or YAML, configuration, and usage. It also covers essential prerequisites and notes on the interplay between these new policies and existing webhooks, ensuring users can effectively implement and manage them. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new documentation for Volcano's Validating Admission Policy (VAP) and Mutating Admission Policy (MAP), with versions in both English and Chinese. The documentation is well-structured, clear, and provides good examples for installation and usage. I've provided a few suggestions to enhance clarity and consistency. Specifically, I've recommended making the commands for verifying policy bindings more user-friendly and aligning a heading in the Chinese document with the English version.
add VAP/MAP doc
…om/suyiiyii/website/issues/416)) add VAP/MAP doc Signed-off-by: suyiiyii <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes: