-
Notifications
You must be signed in to change notification settings - Fork 81
docs: add docs for vnpu usage #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @DSFans2014! It looks like this is your first PR to volcano-sh/website 🎉 |
Summary of ChangesHello @DSFans2014, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new documentation that guides users through the integration and usage of Ascend vNPU devices within a Volcano-managed cluster. It distinguishes between two primary operational modes, MindCluster and HAMi, providing detailed instructions for installation, configuration, and workload deployment to ensure efficient sharing and scheduling of NPU resources. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds comprehensive user guides for Ascend vNPU usage in both English and Chinese. The documentation is well-structured and covers two modes: MindCluster and HAMi. My review focuses on improving clarity, consistency, and correcting some minor grammatical and typographical errors in the markdown files. I've provided suggestions to fix typos, improve grammar, ensure consistent terminology (e.g., 'MindCluster', '310P'), and correct formatting issues like redundant lines and incorrect punctuation.
JesseStutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please render website in local env to make sure everything works fine, BTW, our hugo version is very old, it's hugo v0.57.2
Signed-off-by: james <[email protected]>
Signed-off-by: james <[email protected]>
71cfd34 to
85e5497
Compare
this docs is for the feature
support hami ascend device plugin. refer volcano-sh/volcano#4717