Skip to content

Conversation

@DSFans2014
Copy link

@DSFans2014 DSFans2014 commented Nov 13, 2025

this docs is for the feature support hami ascend device plugin . refer volcano-sh/volcano#4717

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thor-wl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
Copy link
Collaborator

Welcome @DSFans2014! It looks like this is your first PR to volcano-sh/website 🎉

@gemini-code-assist
Copy link

Summary of Changes

Hello @DSFans2014, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new documentation that guides users through the integration and usage of Ascend vNPU devices within a Volcano-managed cluster. It distinguishes between two primary operational modes, MindCluster and HAMi, providing detailed instructions for installation, configuration, and workload deployment to ensure efficient sharing and scheduling of NPU resources.

Highlights

  • New vNPU Documentation: Added comprehensive documentation for utilizing Ascend vNPU devices within Volcano, available in both English and Chinese.
  • Two vNPU Modes Detailed: The documentation clearly outlines two distinct vNPU operational modes: MindCluster mode and HAMi mode, each with specific installation and usage instructions.
  • Installation Guides: Provided detailed installation steps for each vNPU mode, including prerequisites, third-party component setup, and necessary Volcano scheduler configuration updates.
  • Usage Examples: Included practical YAML manifest examples for deploying vNPU-enabled workloads under both MindCluster and HAMi modes, demonstrating resource requests and specific labels.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@volcano-sh-bot volcano-sh-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 13, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds comprehensive user guides for Ascend vNPU usage in both English and Chinese. The documentation is well-structured and covers two modes: MindCluster and HAMi. My review focuses on improving clarity, consistency, and correcting some minor grammatical and typographical errors in the markdown files. I've provided suggestions to fix typos, improve grammar, ensure consistent terminology (e.g., 'MindCluster', '310P'), and correct formatting issues like redundant lines and incorrect punctuation.

Copy link
Member

@JesseStutler JesseStutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please render website in local env to make sure everything works fine, BTW, our hugo version is very old, it's hugo v0.57.2

@volcano-sh-bot volcano-sh-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants