-
Notifications
You must be signed in to change notification settings - Fork 81
Add Cron VolcanoJob Concept #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @GoingCharlie! It looks like this is your first PR to volcano-sh/website 🎉 |
Summary of ChangesHello @GoingCharlie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces detailed documentation for the new Cron VolcanoJob feature within Volcano v1.13. This feature allows users to schedule batch computing tasks, such as AI and big data workloads, to run periodically based on predefined schedules, similar to Kubernetes native CronJobs. The documentation covers the concept, configuration fields, and practical usage scenarios, ensuring users can effectively leverage this new capability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the new Cron VolcanoJob feature in both English and Chinese. The documentation is comprehensive, covering the definition, key fields, and usage examples. I've found a few minor issues related to formatting, consistency, and clarity that could improve the documentation. Specifically, there's some inconsistent formatting in YAML examples and some trailing whitespace. More importantly, I've suggested adding a clarification about the resource kind (CronJob) and its short name (cronvcjob) to avoid potential confusion for users. I also noticed that doc/concepts/cron_volcanoJob.md seems to be a duplicate of the Chinese documentation for the website, which could be a maintenance concern.
| +++ | ||
|
|
||
| ### Introduction | ||
| Cron VolcanoJob, also known as cronvcjob or cronvj, is a custom resource type in Volcano. Users can now periodically create and run Volcano Jobs based on predefined schedules, similar to Kubernetes native CronJobs, enabling scheduled execution of batch computing tasks (such as AI and big data workloads). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid confusion with the native Kubernetes CronJob, it would be helpful to add a note clarifying that this is a Volcano-specific custom resource. For example, you could add:
'Note: While the resource kind is CronJob, it is a custom resource defined by Volcano under the batch.volcano.sh/v1alpha1 API group, distinct from the native Kubernetes CronJob. It can be managed using kubectl with its short names cronvcjob or cronvj.'
content/en/docs/cron_volcanoJob.md
Outdated
| Optional. Deadline in seconds for starting the job if it misses its scheduled time. | ||
|
|
||
| * suspend | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content/en/docs/cron_volcanoJob.md
Outdated
| name: daily-model-training | ||
| spec: | ||
| schedule: "0 2 * * *" # Run daily at 2 AM | ||
| concurrencyPolicy: "Forbid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content/en/docs/cron_volcanoJob.md
Outdated
| Clean up temporary data and log files every Sunday evening to free up cluster storage space. | ||
| ```shell | ||
| apiVersion: batch.volcano.sh/v1alpha1 | ||
| kind: CronJob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| +++ | ||
|
|
||
| ### 定义 | ||
| Cron VolcanoJob, 简称cronvcjob,cronvj,是Volcano自定义的资源类型。用户现在可以根据预定义的调度计划定期创建和运行Volcano Job,类似于Kubernetes原生的CronJob,以实现批量计算任务(如AI和大数据)的定期执行。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,126 @@ | |||
| ### 定义 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file appears to be a duplicate of content/zh/docs/cron_volcanoJob.md (without the frontmatter). Maintaining duplicate content can lead to inconsistencies and increase the maintenance burden. Could you clarify if this duplication is intentional or if one of the files can be removed or generated from the other?
| @@ -0,0 +1,126 @@ | |||
| ### 定义 | |||
| Cron VolcanoJob, 简称cronvcjob,cronvj,是Volcano自定义的资源类型。用户现在可以根据预定义的调度计划定期创建和运行Volcano Job,类似于Kubernetes原生的CronJob,以实现批量计算任务(如AI和大数据)的定期执行。 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/concepts/cron_volcanoJob.md
Outdated
| 可选。如果 job 错过其计划时间,启动 job 的截止时间(秒)。 | ||
|
|
||
| * suspend | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/concepts/cron_volcanoJob.md
Outdated
| name: daily-model-training | ||
| spec: | ||
| schedule: "0 2 * * *" # 每天凌晨2点运行 | ||
| concurrencyPolicy: "Forbid" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc/concepts/cron_volcanoJob.md
Outdated
| 每周日晚上清理临时数据和日志文件,释放集群存储空间。 | ||
| ```shell | ||
| apiVersion: batch.volcano.sh/v1alpha1 | ||
| kind: CronJob |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
64c48ca to
224e53e
Compare
Arhell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
content/en/docs/cron_volcanoJob.md
Outdated
|
|
||
| Optional. Specifies how to manage concurrent executions of jobs created by the Cron VolcanoJob. Must be one of the following: | ||
|
|
||
| Allow (default): Allow concurrent runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
224e53e to
047d483
Compare
047d483 to
58b0762
Compare
Signed-off-by: GoingCharlie <[email protected]>
8718800 to
fb6aa1d
Compare
Signed-off-by: GoingCharlie <[email protected]>
fb6aa1d to
124a995
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JesseStutler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |

Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
/kind documentation
What this PR does / why we need it:
This PR adds comprehensive documentation for the newly introduced Cron VolcanoJob feature in Volcano v1.13, including both Chinese and English versions.
Changes included:
Which issue(s) this PR fixes:
Fixes #429
Special notes for your reviewer: