Hugo update #432
Hugo update #432
Conversation
- Update HUGO_VERSION in netlify.toml for all build contexts - Migrate BlackFriday to Goldmark markdown renderer - Update pagination config to new format Signed-off-by: katara-Jayprakash <[email protected]>
- Remove leading zeros from dateday values (07 -> 7, 01 -> 1, 08 -> 8) - Fix malformed URL with asterisks in Volcano-1.11.0-release.md Signed-off-by: katara-Jayprakash <[email protected]>
Signed-off-by: katara-Jayprakash <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @katara-Jayprakash! It looks like this is your first PR to volcano-sh/website 🎉 |
volcano-sh-bot
added
the
size/XL
Summary of ChangesHello @katara-Jayprakash, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant upgrade of the Hugo static site generator to its latest version, 0.152.2. This update necessitates a series of compatibility changes across the website's configuration and theme files, including a migration to the Goldmark markdown renderer and adjustments to various template functions. The author notes that the PR is still in progress, with some content display issues yet to be resolved, indicating the complexity of adapting the site to the new Hugo environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
@JesseStutler sorry for raising the pr so late I was busy in my universityexam |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Hugo to a much newer version, which is a significant undertaking. The changes correctly address many breaking changes in Hugo, such as the pagination and markdown renderer configuration. However, I've found several critical issues that are likely contributing to the problems you're seeing, and may cause other parts of the site to break. These include critical bugs in a new JavaScript sidebar, and broken formatting in several markdown files which makes the documentation unusable. My review provides specific suggestions to fix these issues. Addressing them should help in getting the site to build and display correctly.
| ```html | ||
| # mkdir -p $GOPATH/src/volcano.sh/ | ||
| # cd $GOPATH/src/volcano.sh/ | ||
| # git clone https://github.com/volcano-sh/volcano.git | ||
| # mkdir -p $GOPATH/src/volcano.sh/ # cd $GOPATH/src/volcano.sh/ # git clone | ||
| https://github.com/volcano-sh/volcano.git | ||
| ``` |
There was a problem hiding this comment.
The commands in this code block have been merged into a single line, which makes them incorrect and not copy-paste friendly for users. Each command should be on its own line. This issue appears in other code blocks in this file as well.
| ```html | |
| # mkdir -p $GOPATH/src/volcano.sh/ | |
| # cd $GOPATH/src/volcano.sh/ | |
| # git clone https://github.com/volcano-sh/volcano.git | |
| # mkdir -p $GOPATH/src/volcano.sh/ # cd $GOPATH/src/volcano.sh/ # git clone | |
| https://github.com/volcano-sh/volcano.git | |
| ``` | |
| # mkdir -p $GOPATH/src/volcano.sh/ | |
| # cd $GOPATH/src/volcano.sh/ | |
| # git clone https://github.com/volcano-sh/volcano.git |
| ```html | ||
| cd $GOPATH/src/volcano.sh/volcano | ||
| make images | ||
| ## Verify your images | ||
| # docker images | ||
| REPOSITORY TAG IMAGE ID CREATED SIZE | ||
| volcanosh/vk-admission latest a83338506638 8 seconds ago 41.4MB | ||
| volcanosh/vk-scheduler latest faa3c2a25ac3 9 seconds ago 49.6MB | ||
| volcanosh/vk-controllers latest 7b11606ebfb8 10 seconds ago 44.2MB | ||
| cd $GOPATH/src/volcano.sh/volcano make images ## Verify your images # docker | ||
| images REPOSITORY TAG IMAGE ID CREATED SIZE volcanosh/vk-admission latest | ||
| a83338506638 8 seconds ago 41.4MB volcanosh/vk-scheduler latest faa3c2a25ac3 9 | ||
| seconds ago 49.6MB volcanosh/vk-controllers latest 7b11606ebfb8 10 seconds ago | ||
| 44.2MB | ||
| ``` |
There was a problem hiding this comment.
This code block is broken due to incorrect line breaks. The commands and the output are jumbled together, making it unreadable and incorrect. Please restore the original line breaks for clarity and correctness.
| ```html | |
| cd $GOPATH/src/volcano.sh/volcano | |
| make images | |
| ## Verify your images | |
| # docker images | |
| REPOSITORY TAG IMAGE ID CREATED SIZE | |
| volcanosh/vk-admission latest a83338506638 8 seconds ago 41.4MB | |
| volcanosh/vk-scheduler latest faa3c2a25ac3 9 seconds ago 49.6MB | |
| volcanosh/vk-controllers latest 7b11606ebfb8 10 seconds ago 44.2MB | |
| cd $GOPATH/src/volcano.sh/volcano make images ## Verify your images # docker | |
| images REPOSITORY TAG IMAGE ID CREATED SIZE volcanosh/vk-admission latest | |
| a83338506638 8 seconds ago 41.4MB volcanosh/vk-scheduler latest faa3c2a25ac3 9 | |
| seconds ago 49.6MB volcanosh/vk-controllers latest 7b11606ebfb8 10 seconds ago | |
| 44.2MB | |
| ``` | |
| cd $GOPATH/src/volcano.sh/volcano | |
| make images | |
| ## Verify your images | |
| # docker images | |
| REPOSITORY TAG IMAGE ID CREATED SIZE | |
| volcanosh/vk-admission latest a83338506638 8 seconds ago 41.4MB | |
| volcanosh/vk-scheduler latest faa3c2a25ac3 9 seconds ago 49.6MB | |
| volcanosh/vk-controllers latest 7b11606ebfb8 10 seconds ago 44.2MB |
| ```html | ||
| # mkdir -p $GOPATH/src/github.com/kubernetes-sigs/ | ||
| # cd $GOPATH/src/github.com/kubernetes-sigs/ | ||
| # git clone https://github.com/kubernetes-sigs/kube-batch | ||
| # mkdir -p $GOPATH/src/github.com/kubernetes-sigs/ # cd | ||
| $GOPATH/src/github.com/kubernetes-sigs/ # git clone | ||
| https://github.com/kubernetes-sigs/kube-batch | ||
| ``` |
There was a problem hiding this comment.
The commands in this code block have been merged onto a few lines, which is incorrect. Please place each command on a new line. This formatting issue is present throughout the file and makes the tutorial difficult to follow.
| ```html | |
| # mkdir -p $GOPATH/src/github.com/kubernetes-sigs/ | |
| # cd $GOPATH/src/github.com/kubernetes-sigs/ | |
| # git clone https://github.com/kubernetes-sigs/kube-batch | |
| # mkdir -p $GOPATH/src/github.com/kubernetes-sigs/ # cd | |
| $GOPATH/src/github.com/kubernetes-sigs/ # git clone | |
| https://github.com/kubernetes-sigs/kube-batch | |
| ``` | |
| # mkdir -p $GOPATH/src/github.com/kubernetes-sigs/ | |
| # cd $GOPATH/src/github.com/kubernetes-sigs/ | |
| # git clone https://github.com/kubernetes-sigs/kube-batch |
| ```html | ||
| apiVersion: batch/v1 | ||
| kind: Job | ||
| metadata: | ||
| name: qj-1 | ||
| spec: | ||
| backoffLimit: 6 | ||
| completions: 6 | ||
| parallelism: 6 | ||
| template: | ||
| metadata: | ||
| annotations: | ||
| scheduling.k8s.io/group-name: qj-1 | ||
| spec: | ||
| containers: | ||
| - image: busybox | ||
| imagePullPolicy: IfNotPresent | ||
| name: busybox | ||
| resources: | ||
| requests: | ||
| cpu: "1" | ||
| restartPolicy: Never | ||
| schedulerName: kube-batch | ||
| --- | ||
| apiVersion: scheduling.incubator.k8s.io/v1alpha1 | ||
| kind: PodGroup | ||
| metadata: | ||
| name: qj-1 | ||
| spec: | ||
| minMember: 6 | ||
| apiVersion: batch/v1 kind: Job metadata: name: qj-1 spec: backoffLimit: 6 | ||
| completions: 6 parallelism: 6 template: metadata: annotations: | ||
| scheduling.k8s.io/group-name: qj-1 spec: containers: - image: busybox | ||
| imagePullPolicy: IfNotPresent name: busybox resources: requests: cpu: "1" | ||
| restartPolicy: Never schedulerName: kube-batch --- apiVersion: | ||
| scheduling.incubator.k8s.io/v1alpha1 kind: PodGroup metadata: name: qj-1 spec: | ||
| minMember: 6 | ||
| ``` |
There was a problem hiding this comment.
This YAML configuration is completely broken due to incorrect formatting. The newlines have been removed, making it invalid YAML. Please restore the correct structure with proper indentation.
apiVersion: batch/v1
kind: Job
metadata:
name: qj-1
spec:
backoffLimit: 6
completions: 6
parallelism: 6
template:
metadata:
annotations:
scheduling.k8s.io/group-name: qj-1
spec:
containers:
- image: busybox
imagePullPolicy: IfNotPresent
name: busybox
resources:
requests:
cpu: "1"
restartPolicy: Never
schedulerName: kube-batch
---
apiVersion: scheduling.incubator.k8s.io/v1alpha1
kind: PodGroup
metadata:
name: qj-1
spec:
minMember: 6| [markup] | ||
| [markup.goldmark] | ||
| [markup.goldmark.renderer] | ||
| unsafe = true # Allow HTML in markdown |
There was a problem hiding this comment.
Enabling unsafe = true in Goldmark allows raw HTML in Markdown files. While this can be useful, it can also introduce security vulnerabilities (like Cross-Site Scripting) if the content is not fully trusted. Since this is a project website, the content is likely controlled, but it's a good practice to avoid this if possible and use shortcodes for complex HTML instead.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
volcano-sh-bot
added
the
do-not-merge/invalid-commit-message
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages: DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 participants
in this pr I update the Hugo version to latest but the pr is still under working I am getting some problems mainly home, about , why volcano content is not showing
What this PR does / why we need it:
Which issue(s) this PR fixes:
Hugo Version Upgrade Causes Project to Stop Running #344