perf(skills): parallelize user+agent skill search - #3011
Merged
Conversation
Previously find_skills queried user_root and agent_root sequentially when no target_uri was given, making latency T_user + T_agent. Replace with parallel execution so latency becomes max(T_user, T_agent). Safety: - ContextVar-based telemetry is per-task isolated under asyncio.gather. - RequestContext is a read-only dataclass, safe to share across tasks. - service.search.find is a read-only vector query with no shared mutable state. - Same pattern already used in observability/usage_audit/inventory.py. Behavior preserved: - First-exception propagation (either failure raises, same as serial). - telemetry payload from user_execution returned (agent's discarded). - Result merging and score-descending sort unchanged.
Contributor
Author
|
Please review my code when you have time. Thanks! @qin-ctx |
qin-ctx
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parallelize user and agent skill space search in find_skills from sequential to concurrent execution.
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes