test(storage): expect ignore_unknown_fields in volcengine update_data bodies (#3775) - #3777
Closed
huangruiteng wants to merge 1 commit into
Closed
Conversation
… bodies Since volcengine#2981, VolcengineCollection/VolcengineApiKeyCollection.update_data always post 'ignore_unknown_fields': True to /api/vikingdb/data/update. The four update_data tests asserted the legacy exact body without that field and failed. Add it to the expected request dicts. Fixes volcengine#3775.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3775.
Since #2981 (
34c191a0, "fix(vikingdb): trust OpenViking schema for volcengine api_key mode"),VolcengineCollection.update_dataandVolcengineApiKeyCollection.update_dataalways post"ignore_unknown_fields": Trueto/api/vikingdb/data/update. Four tests intests/storage/test_volcengine_clients.pyasserted the legacy exact request body and fail withLeft contains 1 more item: {'ignore_unknown_fields': True}.Add
"ignore_unknown_fields": Trueto the four expected request dicts.Validation
pytest tests/storage/test_volcengine_clients.py -q→ 25 passedruff checkclean,py_compilecleanTest-only change; no production code modified.