fix(search): honor skill context for default targets - #4255
Open
AaronZ345 wants to merge 1 commit into
Open
Conversation
Thread a single search context type into default target resolution so skill-only searches include shared agent skills when no explicit target URI is provided. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AaronZ345
force-pushed
the
aaron/fix-skill-context-search-scope
branch
from
September 1, 2026 08:54
5ea4e4e to
5845b34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ov find --context-type skill(and/api/v1/search/findwithcontext_type=skill) silently dropsviking://agent/skills/from the search scope #3739 by threading a singlecontext_typefrom/api/v1/search/findand list-mode/api/v1/search/searchinto default retrieval target resolution.context_type=skillsearches use the same default skill roots as dedicated skill search, includingviking://agent/skills.target_uribehavior unchanged and avoids narrowing default scope for multi-type filters.Test plan
python -m pytest tests/server/test_actor_peer_retrieval_targets.py::test_empty_target_uri_respects_skill_context_type tests/server/test_api_search_context.py::test_find_forwards_context_type_to_search_service tests/server/test_api_search_context.py::test_search_forwards_context_type_to_search_servicepython -m pytest tests/server/test_actor_peer_retrieval_targets.pypython -m ruff check openviking/core/retrieval_targets.py openviking/server/routers/search.py openviking/service/search_service.py openviking/storage/viking_fs/_semantic.py tests/server/test_actor_peer_retrieval_targets.py tests/server/test_api_search_context.pyNote: a full
tests/server/test_api_search_context.pyrun in this local checkout is blocked by the existing local test environment requirement forOPENVIKING_CONFIG_FILE/nativeragfs_python; the new API regression tests avoid that fixture by invoking the route handlers directly.🤖 Generated with Claude Code