fix(memory): redact inline image bytes from extraction - #4456
Open
jianxunzhang1101 wants to merge 1 commit into
Open
fix(memory): redact inline image bytes from extraction#4456jianxunzhang1101 wants to merge 1 commit into
jianxunzhang1101 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent inline image Base64 from being restored into Phase 2 memory-extraction prompts as plain text. The stored session and externalized tool result remain unchanged; only the deep-copied messages used by Working Memory and long-term memory extraction receive bounded placeholders.
Human Involvement
The reporter provided the production incident, provider errors, request-size measurements, and requested the scoped fix.
Related Issue
Fixes #4455
Related to the broader unbounded extraction-input issue #3226.
Type of Change
Changes Made
data:image/...;base64,...and JSONb64_jsonvalues with placeholders containing MIME type and encoded character count.b64_json, and source-message immutability.Testing
A synthetic incident-scale check used 12 tool outputs with 999,992 Base64 characters each. The raw tool text was 12,000,168 characters; the formatted Working Memory input was 1,343 characters and contained no original Base64 payload.
Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
This intentionally does not solve every oversized non-image extraction input under #3226. It removes the demonstrated inline-image failure mode without truncating or deleting the authoritative archived tool result.