fix(retrieval): keep VikingFS.find on quick mode - #4472
Open
ranxi2001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VikingFS.find()did not pass a retrieval mode toHierarchicalRetriever. When areranker is configured, the retriever therefore selected its recursive THINKING path,
even though
findis the fast semantic-retrieval API.This change makes
findexplicitly request QUICK mode.VikingFS.search()keeps itsexisting mode selection, and the public API is unchanged.
Human Involvement
Related Issue
Fixes #4463
Type of Change
Changes Made
RetrieverMode.QUICKfromVikingFS.find()to the hierarchical retriever;findcalls; andTesting
Local checks:
find, hierarchical-retriever, and image search-service tests passed;git diff --checkpassed.The full server search suite was not runnable because this environment has no
~/.openviking/ov.conf. Editable installation is also unavailable because Cargo andthe generated native
openviking/bin/ovartifact are absent. The tests were thereforerun from source using an existing project test environment.
Checklist
Screenshots (if applicable)
Not applicable; this change has no visual output.
Additional Notes
The regression first failed with
assert None == 'quick'. A direct probe of theunmodified retriever with an available reranker also entered two rerank rounds and four
child searches, confirming that the omitted mode selected the recursive path.