fix(semantic): do not materialize missing DAG roots - #4474
Open
ranxi2001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SemanticDagExecutor._list_dir()treated every listing failure as a valid emptydirectory. If a queued semantic root referred to a file removed by chunking, the DAG
therefore continued to sidecar writeback.
VikingFS.write_file()created the missingparent first, turning the old file URI into either an empty directory or a directory
containing only
.abstract.mdand.overview.md.This change preserves the listing exception so the existing dispatch error path stops
that node before any sidecar write. A real empty directory still returns an empty list
and receives its normal generated sidecars.
Human Involvement
Related Issue
Fixes #4461
Type of Change
Changes Made
Testing
Local checks:
git diff --checkpassed.The broader DAG test selection has eight failures on the unmodified base as well: two
tests require a local OpenViking config, and six test doubles do not accept the current
creator_acl_grantkeyword. Editable installation is also unavailable here becauseCargo and the generated native
openviking/bin/ovartifact are absent, so tests wererun from source using an existing project test environment.
Checklist
Screenshots (if applicable)
Not applicable; this change has no visual output.
Additional Notes
This prevents new phantom directories. It intentionally does not remove existing ones,
because automated cleanup cannot safely distinguish them from user-created directories.